Skip to content

Commit

Permalink
chore: bump operator-rs to 0.62.0 (#454)
Browse files Browse the repository at this point in the history
* upgrade operator-rs and remove extra space

* remove legacy node selector code

* remove legacy node selector code

* use new label builders, and change return type

* use new label builders

* fix import

* make discover snafu errors

* fix volume builders

* bump operator-rs for kvp goodies

* upgrade rust to 1.75.0

* fix the label filter/map

* bump operator-rs to 0.62.0 for labels iterator functionality (in previous commits)

* style: convert enum variants with comments/attributes to blocks (only for the enums that was touched in this PR)

* style: reorder imorts (only for the enums that was touched in this PR)

* use cloned instead of map

* update changelog

* use new parse_insert method

* fix error handling after merge

* use module Result typedef for module level errors

* make regenerate-charts

* ci: upgrade toolchain (stackabletech/operator-templating#310)

* fix poor error variant name

* Apply suggestions from code review

Co-authored-by: Natalie <nat.roijezon@stackable.tech>

* remove outdated operator-rs version entry

* rename kerberos::check_if_supported to kerberos::is_supported

* fix kerberos::is_supported bool

* update nixpkgs to get rust 1.75

```
This is version 0.0.0-dev, built for x86_64-unknown-linux-gnu by rustc 1.75.0 (82e1608df 2023-12-21) (built from a source tarball) at Wed, 24 Jan 2024 08:59:02 +0000
```

* double deref

* disambiguate label errors

* fix: kerberos::is_not_supported

* style: error text lower case, remove square brackets

---------

Co-authored-by: Natalie <nat.roijezon@stackable.tech>
  • Loading branch information
NickLarsenNZ and nightkr authored Feb 5, 2024
1 parent c1080fb commit b84cc52
Show file tree
Hide file tree
Showing 18 changed files with 478 additions and 594 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@1.74.0
- uses: dtolnay/rust-toolchain@1.75.0
- uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 # v2.7.1
with:
key: udeps
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@1.74.0
- uses: dtolnay/rust-toolchain@1.75.0
with:
components: rustfmt
- run: cargo fmt --all -- --check
Expand All @@ -139,7 +139,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@1.74.0
- uses: dtolnay/rust-toolchain@1.75.0
with:
components: clippy
- uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 # v2.7.1
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@1.74.0
- uses: dtolnay/rust-toolchain@1.75.0
with:
components: rustfmt
- uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 # v2.7.1
Expand All @@ -195,7 +195,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@1.74.0
- uses: dtolnay/rust-toolchain@1.75.0
- uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 # v2.7.1
with:
key: test
Expand Down Expand Up @@ -258,7 +258,7 @@ jobs:
with:
version: v3.13.3
- name: Set up cargo
uses: dtolnay/rust-toolchain@1.74.0
uses: dtolnay/rust-toolchain@1.75.0
- uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 # v2.7.1
with:
key: charts
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@1.74.0
- uses: dtolnay/rust-toolchain@1.75.0
with:
components: rustfmt
# This step checks if the current run was triggered by a push to a pr (or a pr being created).
Expand Down
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,22 @@ All notable changes to this project will be documented in this file.

### Changed

- `operator-rs` `0.56.1` -> `0.57.0` ([#433]).
- Use new label builders ([#454]).

### Removed

- [BREAKING] `.spec.clusterConfig.listenerClass` has been split to `.spec.nameNodes.config.listenerClass` and `.spec.dataNodes.config.listenerClass`, migration will be required when using `external-unstable` ([#450], [#462]).
- [BREAKING] Removed legacy node selector on roleGroups ([#454]).
- Change default value of `dfs.ha.nn.not-become-active-in-safemode` from `true` to `false` ([#458]).

### Fixed

- Include hdfs principals `dfs.journalnode.kerberos.principal`, `dfs.namenode.kerberos.principal`
and `dfs.datanode.kerberos.principal` in the discovery ConfigMap in case Kerberos is enabled ([#451]).

[#433]: https://github.com/stackabletech/hdfs-operator/pull/433
[#450]: https://github.com/stackabletech/hdfs-operator/pull/450
[#451]: https://github.com/stackabletech/hdfs-operator/pull/451
[#454]: https://github.com/stackabletech/hdfs-operator/pull/454
[#458]: https://github.com/stackabletech/hdfs-operator/pull/458
[#460]: https://github.com/stackabletech/hdfs-operator/pull/460
[#462]: https://github.com/stackabletech/hdfs-operator/pull/462
Expand Down
132 changes: 72 additions & 60 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b84cc52

Please sign in to comment.