Idea: customize install command in GH App

[webpro]

Example output of the GH App:

⚡️ Your npm packages are published.
knip: npm i https://pkg.pr.new/knip@d9ae5dc

This is a command I often copy-paste, so with this in mind two ideas here:

• Ability to add -D or --save-dev for when the lib is a dev dep
• Extending this idea, not necessarily a fan myself, people could prefer to swap npm i for ni or pnpm add etc.

WDYT?

[webpro]

By the way, kinda surprised to see it uses Yarn in the message like here: release-it/conventional-changelog#100 (comment)

[Aslemammad]

Hey, we're working on this to see what we can come up with, sorry for the late response!

Around the message, do you mean the .tgz at the end? if yes, as far as i know, yarn needs that for urls. If it does not need it anymore, we can just remove it. Let me know.

[webpro]

Hey, we're working on this to see what we can come up with, sorry for the late response!

No worries, just spitting out ideas and feedback, hope you don't mind! This project's such a productivity win, it's incredible.

Around the message, do you mean the .tgz at the end? if yes, as far as i know, yarn needs that for urls. If it does not need it anymore, we can just remove it. Let me know.

Guess it's just my pet peeve but what I meant is usage of yarn itself. I believe it isn't de facto standard, and everyone not using npm knows how to translate any command. That's why I thought it's a bit odd to print a command with Yarn without knowing the package manager for the repo that's using the pkg-pr-new GH App.

[Aslemammad]

No worries, just spitting out ideas and feedback, hope you don't mind! This project's such a productivity win, it's incredible.

That's for sure, just feel free to share more, happy to discuss anything.

That's why I thought it's a bit odd to print a command with Yarn without knowing the package manager for the repo that's using the pkg-pr-new GH App.

Oh I see, we have a detect package manager that detects it since users wanted that, but I guess it does not work for you, because your workspace does not use yarn, correct?

[webpro]

Oh I see, we have a detect package manager that detects it since users wanted that, but I guess it does not work for you, because your workspace does not use yarn, correct?

Correct! It's a repo without a lockfile checked in so I'd suspect the default/fallback is Yarn.

[Aslemammad]

We just landed a recipe in #262, it'd teach how you can achieve fully customizable comments thanks to @AmirSa12

[webpro]

Thank you!

[Aslemammad]

You're welcome ❤️

…

On Sat, 12 Oct 2024, 19:28 Lars Kappert, ***@***.***> wrote: Thank you! — Reply to this email directly, view it on GitHub <#260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJBMICG5ZK434JIPY2MBTQLZ3FBLVAVCNFSM6AAAAABPLN22VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGYYDSNJTGQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>