Allow setting expression directly #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthetechie
approved these changes
May 3, 2024
There was a problem hiding this comment.
Sorry for the delay in getting around to this! I think that this is the best path forward for now.
I actually had considered writing a higher-level DSL for expressions too. It looks like that's going from "nice to have" to "will end up in core" sooner, since there is a move to replace NSExpressions entirely (since they are fairly broken at the moment). See maplibre/maplibre-native#331 for discussion upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more advanced use cases, developers may wish to specify NSExpressions directly, for example to show the number of clustered pins in a symbol layer.
This PR allows the setting of NSExpressions directly for advanced use cases, while keeping the convenience of value based modifiers.
This will allow use cases like the one below (separate PR for clustering and text symbol support coming up for Maplibre DSL)