Catch edge case and fix example #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that function won't return negative numbers if the desired point is inside the circle already. Fixed documentation example because it didn't match up with the intended result.
koresar
reviewed
May 25, 2019
| @@ -96,7 +96,13 @@ const Circle = stampit(Point, { | |||
| }, | |||
| methods: { // that goes to the prototype | |||
| distance(point) { | |||
| return Point(point).distance(this) - this.radius; | |||
| // Shouldn't this only return a value if the point is located outside of the circle? | |||
There was a problem hiding this comment.
Thanks for the tips mate.
This function returns positive value if the point is outside the circle. But returns negative value if the point is inside.
|
Thank you for the pr. The intention of this example is to show the reader how stamps can be composed. Math is secondary. Are those examples clear enough to understand the stamps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that function won't return negative numbers if the desired point is inside the circle already
Fix documentation example because it didn't match up with the intended result