From 3f90e9a9e0894a94e80d184e2999d3b77f9b50c2 Mon Sep 17 00:00:00 2001 From: Lev Roitman Date: Wed, 18 Dec 2024 13:43:19 +0200 Subject: [PATCH] chore(starknet_integration_tests): remove holding the node handle in flow tests commit-id:2c8eb8b1 --- Cargo.lock | 1 - crates/starknet_integration_tests/Cargo.toml | 1 - .../starknet_integration_tests/src/flow_test_setup.rs | 11 +++-------- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 318b2ae6af..927c0d9662 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -10488,7 +10488,6 @@ dependencies = [ name = "starknet_integration_tests" version = "0.0.0" dependencies = [ - "anyhow", "assert_matches", "blockifier", "cairo-lang-starknet-classes", diff --git a/crates/starknet_integration_tests/Cargo.toml b/crates/starknet_integration_tests/Cargo.toml index 95a07bf215..441b0bfd61 100644 --- a/crates/starknet_integration_tests/Cargo.toml +++ b/crates/starknet_integration_tests/Cargo.toml @@ -9,7 +9,6 @@ license.workspace = true workspace = true [dependencies] -anyhow.workspace = true assert_matches.workspace = true blockifier.workspace = true cairo-lang-starknet-classes.workspace = true diff --git a/crates/starknet_integration_tests/src/flow_test_setup.rs b/crates/starknet_integration_tests/src/flow_test_setup.rs index b60e067d82..9f6cddac28 100644 --- a/crates/starknet_integration_tests/src/flow_test_setup.rs +++ b/crates/starknet_integration_tests/src/flow_test_setup.rs @@ -17,7 +17,6 @@ use starknet_sequencer_node::config::node_config::SequencerNodeConfig; use starknet_sequencer_node::servers::run_component_servers; use starknet_sequencer_node::utils::create_node_modules; use tempfile::TempDir; -use tokio::task::JoinHandle; use tracing::{debug, instrument}; use crate::state_reader::{spawn_test_rpc_state_reader, StorageTestSetup}; @@ -94,9 +93,7 @@ pub struct SequencerSetup { pub rpc_storage_file_handle: TempDir, pub state_sync_storage_file_handle: TempDir, - // Handle of the sequencer node. - pub sequencer_node_handle: JoinHandle>, - + // Node configuration. pub config: SequencerNodeConfig, // Monitoring client. @@ -142,9 +139,8 @@ impl SequencerSetup { let HttpServerConfig { ip, port } = config.http_server_config; let add_tx_http_client = HttpTestClient::new(SocketAddr::from((ip, port))); - // Build and run the sequencer node. - let sequencer_node_future = run_component_servers(servers); - let sequencer_node_handle = tokio::spawn(sequencer_node_future); + // Run the sequencer node. + tokio::spawn(run_component_servers(servers)); Self { sequencer_index, @@ -152,7 +148,6 @@ impl SequencerSetup { batcher_storage_file_handle: storage_for_test.batcher_storage_handle, rpc_storage_file_handle: storage_for_test.rpc_storage_handle, state_sync_storage_file_handle: storage_for_test.state_sync_storage_handle, - sequencer_node_handle, config, is_alive_test_client, }