From 44bc35e2ffe2e50d8063b5d3b65a37e3a52f2c79 Mon Sep 17 00:00:00 2001 From: Itay Tsabary Date: Mon, 11 Nov 2024 15:23:28 +0200 Subject: [PATCH] chore(monitoring): clean dependencies, add todos commit-id:3bb41b9a --- crates/monitoring_endpoint/Cargo.toml | 6 +++--- crates/monitoring_endpoint/src/monitoring_endpoint_test.rs | 2 -- crates/monitoring_endpoint/src/test_utils.rs | 4 +++- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/monitoring_endpoint/Cargo.toml b/crates/monitoring_endpoint/Cargo.toml index 24c3e8efad..3cce2455fd 100644 --- a/crates/monitoring_endpoint/Cargo.toml +++ b/crates/monitoring_endpoint/Cargo.toml @@ -17,12 +17,12 @@ workspace = true [dependencies] axum.workspace = true http-body = { workspace = true, optional = true } -hyper = { workspace = true, features = ["full"] } +hyper = { workspace = true } papyrus_config.workspace = true serde.workspace = true starknet_sequencer_infra.workspace = true tokio = { workspace = true, optional = true } -tower = { workspace = true, optional = true, features = ["util"] } +tower = { workspace = true, optional = true } tracing.workspace = true validator.workspace = true @@ -30,4 +30,4 @@ validator.workspace = true http-body.workspace = true pretty_assertions.workspace = true tokio.workspace = true -tower = { workspace = true, features = ["util"] } +tower.workspace = true diff --git a/crates/monitoring_endpoint/src/monitoring_endpoint_test.rs b/crates/monitoring_endpoint/src/monitoring_endpoint_test.rs index 150225c0e1..14aa36f4dc 100644 --- a/crates/monitoring_endpoint/src/monitoring_endpoint_test.rs +++ b/crates/monitoring_endpoint/src/monitoring_endpoint_test.rs @@ -22,8 +22,6 @@ use crate::monitoring_endpoint::{ }; use crate::test_utils::build_request; -// TODO(Tsabary): Clear feature dependencies and dev dependencies. - const TEST_VERSION: &str = "1.2.3-dev"; fn setup_monitoring_endpoint() -> MonitoringEndpoint { diff --git a/crates/monitoring_endpoint/src/test_utils.rs b/crates/monitoring_endpoint/src/test_utils.rs index 0fab401dea..9b7b1ba783 100644 --- a/crates/monitoring_endpoint/src/test_utils.rs +++ b/crates/monitoring_endpoint/src/test_utils.rs @@ -9,7 +9,7 @@ use tracing::info; use crate::monitoring_endpoint::{ALIVE, MONITORING_PREFIX}; -// TODO(Tsabary): Clean feature dependencies and dev dependencies. +// TODO(Tsabary): try avoid having to use http-body crate from the dependencies. /// Client for querying 'alive' status of an http server. pub struct IsAliveClient { @@ -33,6 +33,8 @@ impl IsAliveClient { .map_or(false, |response| response.status().is_success()) } + // TODO(Tsabary/Lev): add sleep time as a parameter, and max retries. Consider using + // 'starknet_client::RetryConfig'. /// Blocks until 'alive'. pub async fn await_alive(&self) { let mut counter = 0;