From 4a22a6d46043beb242cd404ebcc8d419ad1c905e Mon Sep 17 00:00:00 2001 From: ShahakShama <70578257+ShahakShama@users.noreply.github.com> Date: Mon, 18 Nov 2024 15:43:43 +0200 Subject: [PATCH] chore(mempool_p2p): remove unused field from config (#2103) --- crates/starknet_mempool_p2p/src/config.rs | 9 +-------- crates/starknet_mempool_p2p/src/lib.rs | 3 ++- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/crates/starknet_mempool_p2p/src/config.rs b/crates/starknet_mempool_p2p/src/config.rs index e4b0317a68..ff32d0f354 100644 --- a/crates/starknet_mempool_p2p/src/config.rs +++ b/crates/starknet_mempool_p2p/src/config.rs @@ -10,19 +10,12 @@ use validator::Validate; pub struct MempoolP2pConfig { #[validate] pub network_config: NetworkConfig, - // TODO: Enter this inside NetworkConfig - pub executable_version: Option, pub network_buffer_size: usize, } impl Default for MempoolP2pConfig { fn default() -> Self { - Self { - network_config: NetworkConfig::default(), - // TODO: Consider filling this once the sequencer node has a name. - executable_version: None, - network_buffer_size: 10000, - } + Self { network_config: NetworkConfig::default(), network_buffer_size: 10000 } } } diff --git a/crates/starknet_mempool_p2p/src/lib.rs b/crates/starknet_mempool_p2p/src/lib.rs index 118cb87c63..08150ddebb 100644 --- a/crates/starknet_mempool_p2p/src/lib.rs +++ b/crates/starknet_mempool_p2p/src/lib.rs @@ -18,7 +18,8 @@ pub fn create_p2p_propagator_and_runner( ) -> (MempoolP2pPropagator, MempoolP2pRunner) { let mut network_manager = NetworkManager::new( mempool_p2p_config.network_config, - mempool_p2p_config.executable_version, + // TODO: Consider filling this once the sequencer node has a name. + None, ); let BroadcastTopicChannels { broadcasted_messages_receiver, broadcast_topic_client } = network_manager