From 68d9518976f49bdc0416f1d926d15aff724d0dcc Mon Sep 17 00:00:00 2001 From: Pearson White Date: Tue, 29 Oct 2024 19:32:32 +0200 Subject: [PATCH] feat(blockifier): add Secp256r1 cairo native syscalls --- .../src/execution/native/syscall_handler.rs | 133 ++++++++++++++---- .../execution/syscalls/syscall_tests/secp.rs | 4 + 2 files changed, 113 insertions(+), 24 deletions(-) diff --git a/crates/blockifier/src/execution/native/syscall_handler.rs b/crates/blockifier/src/execution/native/syscall_handler.rs index 95ae089b40..ffbb38fe52 100644 --- a/crates/blockifier/src/execution/native/syscall_handler.rs +++ b/crates/blockifier/src/execution/native/syscall_handler.rs @@ -5,7 +5,7 @@ use std::hash::RandomState; use std::sync::Arc; use ark_ec::short_weierstrass::{Affine, Projective, SWCurveConfig}; -use ark_ff::PrimeField; +use ark_ff::{BigInt, PrimeField}; use cairo_native::starknet::{ BlockInfo, ExecutionInfo, @@ -18,8 +18,8 @@ use cairo_native::starknet::{ TxV2Info, U256, }; -use cairo_native::starknet_stub::u256_to_biguint; use cairo_vm::vm::runners::cairo_runner::ExecutionResources; +use num_bigint::BigUint; use starknet_api::contract_class::EntryPointType; use starknet_api::core::{ calculate_contract_address, @@ -276,7 +276,7 @@ impl<'state> StarknetSyscallHandler for &mut NativeSyscallHandler<'state> { match syscall_base::get_block_hash_base(self.context, block_number, self.state) { Ok(value) => Ok(value), - Err(e) => Err(self.handle_error(remaining_gas, e.into())), + Err(e) => Err(self.handle_error(remaining_gas, e)), } } @@ -675,46 +675,65 @@ impl<'state> StarknetSyscallHandler for &mut NativeSyscallHandler<'state> { fn secp256r1_new( &mut self, - _x: U256, - _y: U256, - _remaining_gas: &mut u128, + x: U256, + y: U256, + remaining_gas: &mut u128, ) -> SyscallResult> { - todo!("Implement secp256r1_new syscall."); + self.pre_execute_syscall(remaining_gas, self.context.gas_costs().secp256r1_new_gas_cost)?; + + Secp256Point::new(x, y) + .map(|option| option.map(|p| p.into())) + .map_err(|err| self.handle_error(remaining_gas, err)) } fn secp256r1_add( &mut self, - _p0: Secp256r1Point, - _p1: Secp256r1Point, - _remaining_gas: &mut u128, + p0: Secp256r1Point, + p1: Secp256r1Point, + remaining_gas: &mut u128, ) -> SyscallResult { - todo!("Implement secp256r1_add syscall."); + self.pre_execute_syscall(remaining_gas, self.context.gas_costs().secp256r1_add_gas_cost)?; + Ok(Secp256Point::add(p0.into(), p1.into()).into()) } fn secp256r1_mul( &mut self, - _p: Secp256r1Point, - _m: U256, - _remaining_gas: &mut u128, + p: Secp256r1Point, + m: U256, + remaining_gas: &mut u128, ) -> SyscallResult { - todo!("Implement secp256r1_mul syscall."); + self.pre_execute_syscall(remaining_gas, self.context.gas_costs().secp256r1_mul_gas_cost)?; + + Ok(Secp256Point::mul(p.into(), m).into()) } fn secp256r1_get_point_from_x( &mut self, - _x: U256, - _y_parity: bool, - _remaining_gas: &mut u128, + x: U256, + y_parity: bool, + remaining_gas: &mut u128, ) -> SyscallResult> { - todo!("Implement secp256r1_get_point_from_x syscall."); + self.pre_execute_syscall( + remaining_gas, + self.context.gas_costs().secp256r1_get_point_from_x_gas_cost, + )?; + + Secp256Point::get_point_from_x(x, y_parity) + .map(|option| option.map(|p| p.into())) + .map_err(|err| self.handle_error(remaining_gas, err)) } fn secp256r1_get_xy( &mut self, - _p: Secp256r1Point, - _remaining_gas: &mut u128, + p: Secp256r1Point, + remaining_gas: &mut u128, ) -> SyscallResult<(U256, U256)> { - todo!("Implement secp256r1_get_xy syscall."); + self.pre_execute_syscall( + remaining_gas, + self.context.gas_costs().secp256r1_get_xy_gas_cost, + )?; + + Ok((p.x, p.y)) } fn sha256_process_block( @@ -748,9 +767,46 @@ impl<'state> StarknetSyscallHandler for &mut NativeSyscallHandler<'state> { /// secp256k1 and secp256r1 curves through the generic `Curve` parameter. #[derive(PartialEq, Clone, Copy)] struct Secp256Point(Affine); +impl From> for Secp256k1Point { + fn from(Secp256Point(Affine { x, y, infinity }): Secp256Point) -> Self { + Secp256k1Point { + x: big4int_to_u256(x.into()), + y: big4int_to_u256(y.into()), + is_infinity: infinity, + } + } +} + +impl From> for Secp256r1Point { + fn from(Secp256Point(Affine { x, y, infinity }): Secp256Point) -> Self { + Secp256r1Point { + x: big4int_to_u256(x.into()), + y: big4int_to_u256(y.into()), + is_infinity: infinity, + } + } +} + +impl From for Secp256Point { + fn from(p: Secp256k1Point) -> Self { + Secp256Point(Affine { + x: u256_to_big4int(p.x).into(), + y: u256_to_big4int(p.y).into(), + infinity: p.is_infinity, + }) + } +} + +impl From for Secp256Point { + fn from(p: Secp256r1Point) -> Self { + Secp256Point(Affine { + x: u256_to_big4int(p.x).into(), + y: u256_to_big4int(p.y).into(), + infinity: p.is_infinity, + }) + } +} -// todo(xrvdg) remove dead_code annotation after adding syscalls -#[allow(dead_code)] impl Secp256Point where Curve::BaseField: PrimeField, // constraint for get_point_by_id @@ -803,6 +859,35 @@ impl fmt::Debug for Secp256Point { } } +fn u256_to_biguint(u256: U256) -> BigUint { + let lo = BigUint::from(u256.lo); + let hi = BigUint::from(u256.hi); + + (hi << 128) + lo +} + +fn big4int_to_u256(b_int: BigInt<4>) -> U256 { + let [a, b, c, d] = b_int.0; + + let lo = u128::from(a) | (u128::from(b) << 64); + let hi = u128::from(c) | (u128::from(d) << 64); + + U256 { lo, hi } +} + +fn u256_to_big4int(u256: U256) -> BigInt<4> { + fn to_u64s(bytes: [u8; 16]) -> (u64, u64) { + let hi_bytes: [u8; 8] = bytes[0..8].try_into().expect("Take high bytes"); + let hi: u64 = u64::from_le_bytes(hi_bytes); + let lo_bytes: [u8; 8] = bytes[8..16].try_into().expect("Take low bytes"); + let lo: u64 = u64::from_le_bytes(lo_bytes); + (hi, lo) + } + let (hi_hi, hi_lo) = to_u64s(u256.hi.to_le_bytes()); + let (lo_hi, lo_lo) = to_u64s(u256.lo.to_le_bytes()); + BigInt::new([lo_lo, lo_hi, hi_lo, hi_hi]) +} + #[cfg(test)] mod test { use cairo_native::starknet::U256; diff --git a/crates/blockifier/src/execution/syscalls/syscall_tests/secp.rs b/crates/blockifier/src/execution/syscalls/syscall_tests/secp.rs index 3a8d52f098..23e518ae1a 100644 --- a/crates/blockifier/src/execution/syscalls/syscall_tests/secp.rs +++ b/crates/blockifier/src/execution/syscalls/syscall_tests/secp.rs @@ -27,6 +27,10 @@ fn test_secp256k1(test_contract: FeatureContract, expected_gas: u64) { ); } +#[cfg_attr( + feature = "cairo_native", + test_case(FeatureContract::TestContract(CairoVersion::Native), 27573600; "Native") +)] #[test_case(FeatureContract::TestContract(CairoVersion::Cairo1), 27563600; "VM")] fn test_secp256r1(test_contract: FeatureContract, expected_gas: u64) { let chain_info = &ChainInfo::create_for_testing();