Skip to content

Commit

Permalink
chore(batcher): add a comment that send_proposal_content can be block…
Browse files Browse the repository at this point in the history
…ing (#2280)
  • Loading branch information
Yael-Starkware authored Nov 26, 2024
1 parent 2db8897 commit 8533938
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions crates/starknet_batcher_types/src/communication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,8 @@ pub trait BatcherClient: Send + Sync {
async fn validate_block(&self, input: ValidateBlockInput) -> BatcherClientResult<()>;
/// Sends the content of a proposal. Only relevant when validating a proposal.
/// Note:
/// * The batcher acks when the content is received immediately, not waiting for it to finish
/// processing. The next send might receive an `InvalidProposal` response for the previous
/// send.
/// * This call can be blocking if the batcher has too many unprocessed transactions.
/// * The next send might receive an `InvalidProposal` response for the previous send.
/// * If this marks the end of the content, i.e. `SendProposalContent::Finish` is received,
/// the batcher will block until the proposal has finished processing before responding.
async fn send_proposal_content(
Expand Down

0 comments on commit 8533938

Please sign in to comment.