Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove dangling artifact from dependencies.sh #1497

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the dori/remove-dangling-file branch 2 times, most recently from b016265 to 561cf3c Compare October 21, 2024 11:36
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.83%. Comparing base (b0cfe82) to head (561cf3c).
Report is 450 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (561cf3c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (561cf3c)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1497       +/-   ##
==========================================
- Coverage   74.18%   4.83%   -69.36%     
==========================================
  Files         359      34      -325     
  Lines       36240    2109    -34131     
  Branches    36240    2109    -34131     
==========================================
- Hits        26886     102    -26784     
+ Misses       7220    1998     -5222     
+ Partials     2134       9     -2125     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dori Medini <dori@starkware.co>
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.831 ms 33.862 ms 33.897 ms]
change: [-4.0691% -2.4702% -1.0699%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe

@dorimedini-starkware dorimedini-starkware merged commit 75b7b99 into main Oct 21, 2024
22 checks passed
@dorimedini-starkware dorimedini-starkware deleted the dori/remove-dangling-file branch October 21, 2024 12:09
guy-starkware pushed a commit that referenced this pull request Oct 22, 2024
Signed-off-by: Dori Medini <dori@starkware.co>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants