Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier_reexecution): move reexecution test to separate file #2304

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

aner-starkware
Copy link
Contributor

No description provided.

@aner-starkware aner-starkware self-assigned this Nov 27, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.69%. Comparing base (e3165c4) to head (5188981).
Report is 614 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2304      +/-   ##
==========================================
+ Coverage   40.10%   41.69%   +1.59%     
==========================================
  Files          26      205     +179     
  Lines        1895    24047   +22152     
  Branches     1895    24047   +22152     
==========================================
+ Hits          760    10027    +9267     
- Misses       1100    13552   +12452     
- Partials       35      468     +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @AvivYossef-starkware)


crates/blockifier_reexecution/src/state_reader.rs line 9 at r1 (raw file):

pub mod reexecution_test;
#[cfg(test)]
#[cfg(feature = "blockifier_regression_https_testing")]

while you're here :)
non-blocking

Suggestion:

#[cfg(all(test, feature = "blockifier_regression_https_testing"))]

@aner-starkware aner-starkware force-pushed the aner/move_reexecution_test_seperate_file branch from 33e017b to 4fab7c0 Compare November 27, 2024 16:53
@aner-starkware aner-starkware force-pushed the aner/move_reexecution_test_seperate_file branch from 4fab7c0 to 5188981 Compare November 28, 2024 06:27
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@aner-starkware aner-starkware merged commit 46ca924 into main Nov 28, 2024
11 checks passed
@aner-starkware aner-starkware deleted the aner/move_reexecution_test_seperate_file branch November 28, 2024 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants