chore: make sure that the cairo_native flag works in python

[meship-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-05T08:43:46Z
• Started at 2024-12-05T10:17:08Z
• Started at 2024-12-05T11:01:59Z
• Started at 2024-12-05T11:53:00Z
• Started at 2024-12-05T12:32:56Z
• Started at 2024-12-05T12:52:31Z
• Started at 2024-12-05T12:52:31Z
• Started at 2024-12-05T16:24:48Z
• Started at 2024-12-08T10:27:48Z
• Started at 2024-12-09T07:43:48Z
• Started at 2024-12-08T10:27:48Z
• Started at 2024-12-09T08:26:18Z
• Started at 2024-12-09T09:48:26Z
• Started at 2024-12-09T11:25:46Z
• Started at 2024-12-09T11:28:59Z
• Started at 2024-12-09T11:33:51Z
• Started at 2024-12-09T11:36:45Z
• Started at 2024-12-09T12:48:38Z
• Started at 2024-12-09T12:57:21Z
• Started at 2024-12-09T14:19:15Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.28%. Comparing base (e3165c4) to head (cecfbcb).
Report is 781 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #2465       +/-   ##
==========================================
- Coverage   40.10%   9.28%   -30.82%     
==========================================
  Files          26     138      +112     
  Lines        1895   18350    +16455     
  Branches     1895   18350    +16455     
==========================================
+ Hits          760    1704      +944     
- Misses       1100   16305    +15205     
- Partials       35     341      +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)

---

a discussion (no related file):
blocking (this is only a test PR and shouldn't be merged, right?)

[meship-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

a discussion (no related file):

Previously, dorimedini-starkware wrote…

blocking (this is only a test PR and shouldn't be merged, right?)

Yes, I don't know why You and Yoni are reviewers

[Yoni-Starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

a discussion (no related file):

Previously, meship-starkware (Meshi Peled) wrote…

Yes, I don't know why You and Yoni are reviewers

Does it work?
Let's merge it! to make sure native does not break

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)

---

a discussion (no related file):

Previously, Yoni-Starkware (Yoni) wrote…

Does it work?
Let's merge it! to make sure native does not break

what? why?
we don't (I think) want to add native to all CI, just the feature-combo build...
(change the blockifier ==> change the native blockifier ==> trigger tests with native active)

and if this is to be merged, I have an objection to initializing the submodule in different places (in the main CI);
can the checkout step be part of the bootstrapping action...?
if you are running the bootstrap action you are relying on scripts from the repo, so the checkout should probably coupled with the bootstrap anyway

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

a discussion (no related file):

Previously, dorimedini-starkware wrote…

what? why?
we don't (I think) want to add native to all CI, just the feature-combo build...
(change the blockifier ==> change the native blockifier ==> trigger tests with native active)

and if this is to be merged, I have an objection to initializing the submodule in different places (in the main CI);
can the checkout step be part of the bootstrapping action...?
if you are running the bootstrap action you are relying on scripts from the repo, so the checkout should probably coupled with the bootstrap anyway

@meship-starkware worth checking (but keep it mind that we might be able to get rid of the submodule soon)

We will run native E2E very soon, so turning this feature on is a high priority.

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

a discussion (no related file):

Previously, Yoni-Starkware (Yoni) wrote…

@meship-starkware worth checking (but keep it mind that we might be able to get rid of the submodule soon)

We will run native E2E very soon, so turning this feature on is a high priority.

It does not work. It does not build the artifact because we don't have the Cairo native submodules. I am working on a solution

[meship-starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

.github/workflows/upload_artifacts_workflow.yml line 74 at r2 (raw file):

      - uses: ./.github/actions/bootstrap
      - name: Initialize and update submodules
        run: git submodule update --init --recursive

I don't think this is a good solution; I just want to see if it can build the artifact with that.

Code quote:

      - name: Initialize and update submodules
        run: git submodule update --init --recursive

[dorimedini-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware and @meship-starkware)

---

scripts/build_native_blockifier.sh line 23 at r3 (raw file):

}

init_submodule &&

is this the correct syntax for "run and exit if failed"?

Code quote:

init_submodule &&

---

.github/workflows/main.yml line 117 at r3 (raw file):

          # Fetch the entire history.
          fetch-depth: 0
      - uses: ./.github/actions/bootstrap

should this be part of the bootstrap script? you can init submodules inside it, no?

Code quote:

        with:
          # required to clone native as a gitsubmodule
          submodules: recursive
          # Fetch the entire history.
          fetch-depth: 0
      - uses: ./.github/actions/bootstrap

[meship-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware and @dorimedini-starkware)

---

scripts/build_native_blockifier.sh line 23 at r3 (raw file):

Previously, dorimedini-starkware wrote…

is this the correct syntax for "run and exit if failed"?

According to Copilot this is the syntax or run and only run the next command upon success.

[meship-starkware]

Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware, @dorimedini-starkware, and @Yoni-Starkware)

---

.github/workflows/main.yml line 117 at r3 (raw file):

Previously, dorimedini-starkware wrote…

should this be part of the bootstrap script? you can init submodules inside it, no?

It seems like the - uses: actions/checkout@v4 should happen before calling the bootstrap script because otherwise, it does not know the script.

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @meship-starkware)

---

.github/workflows/main.yml line 117 at r3 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

It seems like the - uses: actions/checkout@v4 should happen before calling the bootstrap script because otherwise, it does not know the script.

yes but you can checkout without submodule init, and later explicitly init using a git command, during bootstrapping.
I prefer to share this code, rather than duplicate it

[dorimedini-starkware]

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @meship-starkware)

---

.github/workflows/main.yml line 108 at r5 (raw file):

        with:
          # required to clone native as a gitsubmodule
          submodules: recursive

delete

Code quote:

          # required to clone native as a gitsubmodule
          submodules: recursive

[dorimedini-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @meship-starkware)

[meship-starkware]

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @dorimedini-starkware)

---

.github/workflows/main.yml line 108 at r5 (raw file):

Previously, dorimedini-starkware wrote…

delete

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)