Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_integration_tests): remove holding the node handle in … #2753

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

lev-starkware
Copy link
Contributor

@lev-starkware lev-starkware commented Dec 18, 2024

…flow tests

commit-id:2c8eb8b1

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved


crates/starknet_integration_tests/src/flow_test_setup.rs line 98 at r1 (raw file):

    // Handle of the sequencer node.
    pub sequencer_node_handle: JoinHandle<Result<(), anyhow::Error>>,

Since anyhow was removed from it, it should also be removed the crate's Cargo.toml file.

Code quote:

anyhow::Error>

@lev-starkware lev-starkware force-pushed the pr/lev-starkware/lev/check_alive/2c8eb8b1 branch from ea13708 to 3f90e9a Compare December 18, 2024 12:57
Copy link

github-actions bot commented Dec 18, 2024

Artifacts upload workflows:

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [35.223 ms 35.259 ms 35.296 ms]
change: [-4.3138% -2.8348% -1.5236%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe

Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

@lev-starkware lev-starkware changed the title chore(starknet_integration_tests): remove holding the node handle in flow tests chore(starknet_integration_tests): remove holding the node handle in … Dec 18, 2024
@lev-starkware lev-starkware merged commit f3276c7 into main Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants