Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performer Image Malformed via Local Image URL when API/Creds Enabled #5538

Open
Serechops opened this issue Dec 7, 2024 · 4 comments
Open
Labels
bug Something isn't working

Comments

@Serechops
Copy link

Describe the bug
When setting a performer image via a local image URL when credentials/API key is set, the image becomes malformed. With no auth, the image updates and persists as normal.

To Reproduce
Steps to reproduce the behavior:

  • Ensure credentials and API are disabled
  • Set performer image via URL and use a local image URL
  • The performer image is updated successfully and persists

Now, set credentials and generate API key

  • Set performer image via URL and use local image URL
  • The performer image is updated successfully at first, however on page reload, the image is malformed.

Expected behavior
The performer image should persist after being updated, but instead it malforms and no image is shown.

Screenshots
Please see the attached screenshots.

abella_malformed
abella_malformed_2

Stash Version: (from Settings -> About):

v0.27.2
Build hash:
76648fee
Build time:
2024-10-15 22:17:23

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.109 (Official Build) (64-bit)

Smartphone (please complete the following information):
Desktop PC

Additional context
Problem first reported by user @nofinway on Discord when reporting an issue using my stashRightClickPerformers plugin to attempt to update a performer image via a local gallery image while having credentials and API enabled.

@Serechops Serechops added the bug report Bug reports that are not yet verified label Dec 7, 2024
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Dec 7, 2024
@Serechops Serechops changed the title [Bug Report] Short Form Subject (50 Chars or less) Performer Image Malformed via Local URL when API/Creds Enabled Dec 7, 2024
@Serechops Serechops changed the title Performer Image Malformed via Local URL when API/Creds Enabled Performer Image Malformed via Local Image URL when API/Creds Enabled Dec 7, 2024
@Valkyr-JS
Copy link

Also found this to be an issue using my merge plugin, reported by Dogma Dragon and I've been able to replicate. It works absolutely fine without credentials. I tried adding the API key to the request, but no change.

@DogmaDragon
Copy link
Collaborator

Reproduced on 76648fe

@DogmaDragon DogmaDragon added bug Something isn't working and removed bug report Bug reports that are not yet verified labels Dec 16, 2024
@feederbox826
Copy link
Contributor

The image link provided in the UI assumes that the cookies are inherited, what happens when you pass your apikey via the &apikey parameter?

@Valkyr-JS
Copy link

The image link provided in the UI assumes that the cookies are inherited, what happens when you pass your apikey via the &apikey parameter?

Just gave this a go and it doesn't work for me. I tried in my plugin and also in the performer edit screen. If you add image by URL, you can see the image come up in the preview, but after saving it breaks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To triage
Development

No branches or pull requests

4 participants