Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Handy script starts playing before video finishes buffering #5575

Open
dumdum7 opened this issue Dec 27, 2024 · 0 comments · May be fixed by #5576
Open

[Bug Report] Handy script starts playing before video finishes buffering #5575

dumdum7 opened this issue Dec 27, 2024 · 0 comments · May be fixed by #5576
Labels
bug report Bug reports that are not yet verified

Comments

@dumdum7
Copy link
Contributor

dumdum7 commented Dec 27, 2024

Describe the bug
Handy script starts playing before video finishes buffering, which causes them to be unsynchronized. This happens because we trigger the Handy /play API call in the "play" event listener instead of "playing". The former is triggered when you click the play button, while the latter is triggered when the video actually starts playing.

To Reproduce
Steps to reproduce the behavior:

  1. Play an interactive scene
  2. Turn on network throttling in devtools to trigger buffering in the next step
  3. Seek through video to trigger the buffering
  4. Notice the /play Handy API call being triggered before the buffering finishes

Expected behavior
Script should start playing after buffering is finished.

Stash Version: (from Settings -> About): v0.27.2

Desktop (please complete the following information):

  • OS: Windows
  • Browser [e.g. chrome, safari]: Chrome
  • Version [e.g. 22]: 131
@dumdum7 dumdum7 added the bug report Bug reports that are not yet verified label Dec 27, 2024
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Dec 27, 2024
@dumdum7 dumdum7 linked a pull request Dec 27, 2024 that will close this issue
@dumdum7 dumdum7 changed the title [Bug Report] Handy script plays before video finishes buffering [Bug Report] Handy script starts playing before video finishes buffering Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: To triage
Development

Successfully merging a pull request may close this issue.

1 participant