Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ENV["REDIS_URL"] out of the box #135

Open
dup2 opened this issue Aug 28, 2023 · 0 comments
Open

Support ENV["REDIS_URL"] out of the box #135

dup2 opened this issue Aug 28, 2023 · 0 comments

Comments

@dup2
Copy link

dup2 commented Aug 28, 2023

While reading the documentation for most other redis clients (in different languages) I found that the environment variable REDIS_URL is supported and being used out of the box for most implementation.

This helps in setting up CI jobs and container based environment as you do not have to call specific initialiser code in the project and for specs, mocking is much easier to achieve.

I see that at the moment the fallback is "hardcoded" to localhost:6379 via default parameter values. This would probably need a change in a way that they could be nil and then first ENV["REDIS_URL"] is checked and afterwards the fallback is "localhost:6379" as it is now.

What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant