1682 fix init test #1738
1682 fix init test #1738
Conversation
Ifropc
force-pushed
the
1682-help-tests
branch
2 times, most recently
from
e4b3254 to
2b58f20
Compare
Ifropc
force-pushed
the
1682-init-test
branch
from
9fca61a to
36a1daf
Compare
Ifropc
force-pushed
the
1682-init-test
branch
from
36a1daf to
e072813
Compare
| @@ -5,7 +5,7 @@ members = [ | |||
| ] | |||
|
|
|||
| [workspace.dependencies] | |||
| soroban-sdk = "21.0.0" | |||
| soroban-sdk = "22.0.0-rc.3" | |||
There was a problem hiding this comment.
The CLI should probably only ever generate templates for stable releases, not release candidates. Even if folks are using an RC of the CLI it's unclear to me it should encourages folks to adopt other unstable software releases in other areas. Can we keep this as the stable?
| soroban-sdk = "22.0.0-rc.3" | |
| soroban-sdk = "22.0.0" |
There was a problem hiding this comment.
I think this check was more for our development process, but if we are fine with tests temporarily failing in dev once we bump the version, then I agree we should make it always stable
There was a problem hiding this comment.
Why would the test fail? I'm suggesting that the init function should generate from a template that is always the latest stable, so that might mean that 22-rc should be initing with an sdk that is 21.
There was a problem hiding this comment.
Oh I see what you mean. Previously test was failing because cli version is 22-rc and test checks that the template uses same major version. Should we keep that condition (test will fail on rc though) or maybe allow for -rc to use previous stable version?
| if is_rc { | ||
| sdk_version.and_then(|x| x.split('-').next()) == Some(&format!("{major}.0.0")) | ||
| } else { | ||
| sdk_version == Some(&format!("{major}.0.0")) |
There was a problem hiding this comment.
I think we should write an assertion that the generated template is always a stable, non-rc version. See other comment.
What
As part of #1682 fix init test.
Moves
init_and_deployinto./integrationas it uses quickstart image to deploy.For existing
inittest allow to use-rcSDK if our current version is-rcitself.Update template soroban SDK version to
22-rc3Why
Test fixes
Known limitations
Some unrelated tests fail, see #1682