Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.location.href doesn't actually request from server again #38

Open
wchen-r7 opened this issue May 24, 2014 · 4 comments
Open

window.location.href doesn't actually request from server again #38

wchen-r7 opened this issue May 24, 2014 · 4 comments

Comments

@wchen-r7
Copy link
Contributor

On Internet Explorer 10, it seems window.location.href demonstrated in SimpleExample.html doesn't actually send a new request to the node's server for the next testcase. If there are no requests being made by the fuzzer, @@count in server.rb will not update, therefore it will not able to move on to the next fuzzer. The code I'm talking about is here:
https://github.com/stephenfewer/grinder/blob/master/node/core/server.rb#L84

My solution to this is this:
http://msdn.microsoft.com/en-us/library/ie/ms536691(v=vs.85).aspx

Use location.reload(true) with a timeout, it has to be true because that reloads the document from the server. It has to be in a timeout because it looks like if you're requesting too rapidly, it doesn't seem to want to reload from the server, either.

However, I have not done enough testing on different versions of IE, and different browsers. So even though this solution works for me, it's not enough as a pull request.

@stephenfewer
Copy link
Owner

Awesome, thanks for the bug report, I'll investigate further to confirm how other browsers are handling this (I know its working for some as my nodes are cycling through fuzzers).

It might work to wrap a location.reload/location.href into a function in the LOGGER class, like logger.restart() or something to work across different browsers.

Thanks again!

@wchen-r7
Copy link
Contributor Author

Thanks!

@mutfuzz
Copy link
Contributor

mutfuzz commented Jun 12, 2014

my nodes also are cycling (on IE11), however what i do is to change the
options in IE to "check for newer versions of stored pages" --> "every time
i visit the webpage"

you can find this option in General --> Settings [under browsing history]

On 11 June 2014 23:59, sinn3r notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#38 (comment).

@wchen-r7
Copy link
Contributor Author

@mutfuzz That sounds like a legit solution. Yeah you just need to force IE to actually request the webpage. When I add a "cache-control" header in the response it works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants