Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linking to players with multiple identities #673

Open
6 tasks
sussexrick opened this issue Oct 10, 2024 · 0 comments
Open
6 tasks

Enable linking to players with multiple identities #673

sussexrick opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement New feature or request statistics Player, match or team statistics

Comments

@sussexrick
Copy link
Member

sussexrick commented Oct 10, 2024

When on the page to link one player identity to another, we do not offer to link to identities which belong to players with other identities because the UI cannot show that relationship, and it would be counter-intuitive to select one identity and be presented with three extra ones. Update the autocomplete UI to display the linked identities and then enable them to be linked.

  • Write an integration test to show that ReadPlayerIdentities will populate the Player.PlayerIdentities collection of each result. This should fail where the PlayerQuery.Query property is used. Make it pass.
  • Write tests and a short method to automate generating the "linked to" text, using the logic currently in EditPlayersForTeam.cshtml
  • Update PlayersApiController.AutoComplete to be able to return results with the "linked to" text included.
  • Update PlayerRespository and its tests to enable these identities to be linked. Update Players.md to say that it's implemented.
  • When you select one linked identity it is added to the table (eg Jane Smith aka J Smith). At this point the other linked identities (eg J Smith aka Jane Smith) must be excluded from the next autocomplete dropdown.
  • Update Players.md.
@sussexrick sussexrick added enhancement New feature or request statistics Player, match or team statistics labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request statistics Player, match or team statistics
Projects
None yet
Development

No branches or pull requests

1 participant