XSPF export omits playlist's title

[eduarrrd]

• I have checked the FAQ for answers.
• I have checked the Changelog that the issue is not already fixed.
• I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
When saving a playlist in XSPF format, the playlist's title, as seen in Strawberry's UI, is not exported as part of the playlist. Depending on the consumer, this results in the filename being re-used as the playlist title. This prevents users from renaming the files without inserting the tag manually. Even if the file is consumed exactly as exported, the playlist title as show by the player may retain the file extension which is undesirable.

To Reproduce

1. Create a new playlist called "MyPlaylist"
2. Save it using the XSPF format.
3. grep MyPlaylist MyPlaylist.xspf returns no results

Expected behavior
File content should be something like

<?xml version="1.0" encoding="UTF-8"?>
<playlist version="1" xmlns="http://xspf.org/ns/0/">
  <title>MyPlaylist</title> <!-- <= this -->
  <trackList>
    <track><location>file:///music/song1.ogg</location></track>
  </trackList>
</playlist>

instead.

Screenshots:
N/A

System Information:

• Strawberry Version: Version 1.2.2

Additional context

• Relevant part of the spec: https://www.xspf.org/spec#41121-title
• Likely place of code change:

  strawberry/src/playlistparsers/xspfparser.cpp

  Line 152 in 53c72d4
  (title still needs to be propagated into the function though).

[clementine-user]

While it would be nice to have the title saved in the playlist, it is not required by the specification https://www.xspf.org/spec#41121-title—indicated by 'MAY'. The current format is probably legacy Clementine code.

[eduarrrd]

I don't believe I claimed it was required by the spec. I still think it's a bug because it introduces an unnecessary limitation playlist names.

Another scenario:

• name playlist "Black / White / Grey"
• click save, see suggestion " Grey.xspf"
  • the leading space is arguably a bug too
• try saving it as Black / White / Grey.xspf, knowing that's not a legal name
• realize that getting the name of the playlist into your music play is impossible with Strawberry as the only way to express slashes is via the title tag.
• On other OSs/FSs this also affects <>:?!"\|*