-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding interfaces #383
Labels
Comments
Please submit a PR that would demonstrate the idea. |
@michaelklishin Sorry for the delay, but I've submitted draft PR to demonstrate the idea in #387 so please, have a look and let me know what you think. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi.
I'm using this library quite a lot recently and always have to write my own interfaces or wrappers for connection and channel, because I couldn't find any interfaces for them inside this library.
How about adding the smallest possible interfaces for basic structures like amqp.Connection or amqp.Channel? It would allow developers to write unit tests for the functions that uses them.
I'm willing to help in this manner, but would like to get your approval for this feature first, @streadway.
Kind regards
The text was updated successfully, but these errors were encountered: