Embedded Appearance API #9706
Open
Embedded Appearance API #9706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
| @@ -182,6 +183,7 @@ private fun CustomizationCard( | |||
| } | |||
| } | |||
|
|
|||
| @OptIn(ExperimentalEmbeddedPaymentElementApi::class) | |||
There was a problem hiding this comment.
Required because the method calls copy on Appearance
|
@tjclawson-stripe can you link the API review please? |
|
We should also |
Done 👍 |
Added 👍 |
paymentsheet/api/paymentsheet.api
Outdated
| public synthetic fun newArray (I)[Ljava/lang/Object; | ||
| } | ||
|
|
||
| public final class com/stripe/android/paymentsheet/PaymentSheet$Appearance$Embedded$RowStyle$FloatingButton : com/stripe/android/paymentsheet/PaymentSheet$Appearance$Embedded$RowStyle { |
There was a problem hiding this comment.
You'll need to restrict the nested classes as well.
jaynewstrom-stripe
requested changes
Nov 26, 2024
| @@ -606,32 +606,6 @@ public final class com/stripe/android/paymentsheet/PaymentSheet$Address$Creator | |||
| public synthetic fun newArray (I)[Ljava/lang/Object; | |||
| } | |||
|
|
|||
| public final class com/stripe/android/paymentsheet/PaymentSheet$Appearance : android/os/Parcelable { | |||
There was a problem hiding this comment.
How come this got removed?
| @@ -881,6 +883,8 @@ class PaymentSheet internal constructor( | |||
| } | |||
|
|
|||
| @Parcelize | |||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
There was a problem hiding this comment.
We don't want to restrict all of appearance! That would be bad! I think you meant to restrict the constructor.
| @@ -10,6 +11,7 @@ import org.robolectric.RobolectricTestRunner | |||
|
|
|||
| @RunWith(RobolectricTestRunner::class) | |||
| class CustomerSheetConfigurationTest { | |||
| @OptIn(ExperimentalEmbeddedPaymentElementApi::class) | |||
There was a problem hiding this comment.
This shouldn't be needed, otherwise merchants will need to do the same.
| @@ -227,6 +228,7 @@ class BacsConfirmationDefinitionTest { | |||
| assertThat(launchAction.receivesResultInProcess).isTrue() | |||
| } | |||
|
|
|||
| @OptIn(ExperimentalEmbeddedPaymentElementApi::class) | |||
There was a problem hiding this comment.
This shouldn't be needed, otherwise merchants will need to do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Appearance API for Embedded Payment Element
Motivation
MOBILESDK-2715
API Review
Testing