Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VVdec version in find_package call needs update #1403

Open
L4cache opened this issue Nov 21, 2024 · 2 comments
Open

VVdec version in find_package call needs update #1403

L4cache opened this issue Nov 21, 2024 · 2 comments

Comments

@L4cache
Copy link

L4cache commented Nov 21, 2024

VVdec is now 3.0.0, it will be ignored because the target version in CMakeLists.txt is 2.3.0, this can be fixed by simply update the target version, but they also mentioned "changes the API" in the release note, maybe there's more to it.

@farindk
Copy link
Contributor

farindk commented Nov 21, 2024

I have tested with vvdec 3.0.0. It works without change.

However, I am not sure how to modify the CMakeLists.txt. Fixing it to a specific version does not seem to be the best approach. cmake >=3.19 should be able to accept a version range, but it did not work for me.

@L4cache
Copy link
Author

L4cache commented Nov 22, 2024

I think the version check is determined by vvdec's cmake file
https://github.com/fraunhoferhhi/vvdec/blob/master/cmake/install/vvdecConfigVersion.cmake.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants