Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sophora-image-update-service] SIMSI-111: remove readiness probe #128

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[sophora-image-update-service] SIMSI-111: remove readiness probe #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd091d8
SIMSI-111: Remove readiness probe
Oct 29, 2024
4d8cc54
SIMSI-111: Update chart version
Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/sophora-image-update-service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.1
version: 1.0.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
14 changes: 2 additions & 12 deletions charts/sophora-image-update-service/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,7 @@ spec:
{{- with .Values.livenessProbe }}
livenessProbe:
httpGet:
path: /actuator/health
port: http
failureThreshold: {{ .failureThreshold }}
initialDelaySeconds: {{ .initialDelaySeconds }}
periodSeconds: {{ .periodSeconds }}
timeoutSeconds: {{ .timeoutSeconds }}
{{- end }}
{{- with .Values.readinessProbe }}
readinessProbe:
httpGet:
path: /actuator/health
path: /actuator/health/liveness
port: http
failureThreshold: {{ .failureThreshold }}
initialDelaySeconds: {{ .initialDelaySeconds }}
Expand All @@ -83,7 +73,7 @@ spec:
{{- with .Values.startupProbe }}
startupProbe:
httpGet:
path: /actuator/health
path: /actuator/health/liveness
port: http
failureThreshold: {{ .failureThreshold }}
initialDelaySeconds: {{ .initialDelaySeconds }}
Expand Down
6 changes: 0 additions & 6 deletions charts/sophora-image-update-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,6 @@ startupProbe:
timeoutSeconds: 3
periodSeconds: 2

readinessProbe:
failureThreshold: 3
initialDelaySeconds: 1
timeoutSeconds: 3
periodSeconds: 5

livenessProbe:
failureThreshold: 1
initialDelaySeconds: 1
Expand Down
Loading