From 3f633f2766e953d4a885966d43448f262867bc81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ingo=20M=C3=BCller?= <ingomueller@google.com>
Date: Tue, 24 Sep 2024 09:18:56 +0200
Subject: [PATCH] fix: use proper string concatenation for error on unsupported
 types (#125)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The previous default template instances of `decodeType` for parametrized
types used a "concatenation" on two char pointers, which doesn't work.
This PR fixes that by making one of the two an `std::string`. The error
did not show up until now because all supported types have
specializations of the template.

---------

Signed-off-by: Ingo Müller <ingomueller@google.com>
---
 src/substrait/type/Type.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/substrait/type/Type.cpp b/src/substrait/type/Type.cpp
index 5a0e3cff..9581607a 100644
--- a/src/substrait/type/Type.cpp
+++ b/src/substrait/type/Type.cpp
@@ -40,7 +40,8 @@ ParameterizedTypePtr decodeType(
     bool nullable,
     const std::vector<ParameterizedTypePtr>& parameterTypes) {
   SUBSTRAIT_UNSUPPORTED(
-      "Unsupported parameter type: " + TypeTraits<Kind>::kTypeString);
+      std::string("Unsupported parameter type: ") +
+      TypeTraits<Kind>::kTypeString);
 }
 
 template <>