From 3f840144fda667a62b04bb989bc586ae620636f5 Mon Sep 17 00:00:00 2001
From: David Sisson <EpsilonPrime@users.noreply.github.com>
Date: Fri, 15 Mar 2024 00:40:48 -0700
Subject: [PATCH] fix:  get CI working again (#102)

Adds an explicit timeout and retry to ensure that we don't run too long
(and can identify any tests that are getting stalled out).
---
 .github/workflows/build_test.yml | 12 ++++++++----
 CMakeLists.txt                   |  2 +-
 export/planloader/CMakeLists.txt |  7 -------
 3 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml
index 87a1fe14..e69559ea 100644
--- a/.github/workflows/build_test.yml
+++ b/.github/workflows/build_test.yml
@@ -35,11 +35,15 @@ jobs:
         with:
           submodules: recursive
       - name: Setup Ubuntu
-        run: ./scripts/setup-ubuntu.sh
-      - run: mkdir build
+        run: |
+          ./scripts/setup-ubuntu.sh
+          mkdir build
       - name: Run cmake
-        run: cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TZ_LIB=ON
+        run: |
+          cmake --version
+          cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TZ_LIB=ON
       - name: Build
         run: ninja -C build
       - name: Test
-        run: ctest --test-dir build --output-on-failure
+        run: ctest --test-dir build --output-on-failure --timeout 30
+
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2c977ce3..025d6c22 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -14,7 +14,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)
 
 option(SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD
        "Turns on address and undefined memory sanitization runtime checking."
-       ON)
+       OFF)
 
 if(${SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD})
   add_compile_options($<$<CONFIG:Debug>:-fsanitize=undefined>)
diff --git a/export/planloader/CMakeLists.txt b/export/planloader/CMakeLists.txt
index 2294572c..e33353a9 100644
--- a/export/planloader/CMakeLists.txt
+++ b/export/planloader/CMakeLists.txt
@@ -1,12 +1,5 @@
 # SPDX-License-Identifier: Apache-2.0
 
-if(CMAKE_BUILD_TYPE MATCHES Debug)
-  message(
-    WARNING
-      "The planloader library does not work well in Debug mode due to bundled heap checking."
-  )
-endif()
-
 add_library(planloader SHARED planloader.cpp)
 
 add_dependencies(planloader substrait_io)