From 603eae23d818701fc0287f9471dbf5215b1cab56 Mon Sep 17 00:00:00 2001
From: David Sisson <EpsilonPrime@users.noreply.github.com>
Date: Thu, 25 Jul 2024 21:00:07 -0700
Subject: [PATCH] try using environment variables

---
 .clang-tidy               | 2 +-
 scripts/run-clang-tidy.sh | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.clang-tidy b/.clang-tidy
index da3ed517..973b72d5 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -77,7 +77,7 @@ Checks: >
   -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-unchecked-optional-access
 WarningsAsErrors: '*'
-HeaderFilterRegex: 'io/substrait/.*\\.h$|protobuf/.*\\.h$'
+HeaderFilterRegex: 'io/substrait/.*\\.h$'
 AnalyzeTemporaryDtors: false
 FormatStyle: none
 CheckOptions:
diff --git a/scripts/run-clang-tidy.sh b/scripts/run-clang-tidy.sh
index 293ef869..211d4458 100755
--- a/scripts/run-clang-tidy.sh
+++ b/scripts/run-clang-tidy.sh
@@ -4,6 +4,7 @@ SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 WORKDIR="$( cd $SCRIPTDIR/.. && pwd )"
 
 # Make compile_command.json
+export CXXFLAGS=-Wno-attributes
 rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_ROUNDTRIP_TESTING=ON
 # Build substrait protobuf
 pushd tmp/src/substrait/proto && make -j && popd || exit