From 68e7e607b0420565645eaa5ea0af461400a9a2f9 Mon Sep 17 00:00:00 2001 From: David Sisson Date: Wed, 26 Jul 2023 20:34:27 -0700 Subject: [PATCH] More signature changes. --- src/substrait/textplan/converter/SaveBinary.cpp | 8 ++++---- src/substrait/textplan/converter/SaveBinary.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/substrait/textplan/converter/SaveBinary.cpp b/src/substrait/textplan/converter/SaveBinary.cpp index a601685e..7f466a55 100644 --- a/src/substrait/textplan/converter/SaveBinary.cpp +++ b/src/substrait/textplan/converter/SaveBinary.cpp @@ -20,7 +20,7 @@ namespace io::substrait::textplan { absl::Status savePlanToBinary( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename) { + std::string_view output_filename) { int outputFileDescriptor = creat(std::string{output_filename}.c_str(), S_IREAD | S_IWRITE); if (outputFileDescriptor == -1) { @@ -42,7 +42,7 @@ absl::Status savePlanToBinary( absl::Status savePlanToJson( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename) { + std::string_view output_filename) { int outputFileDescriptor = creat(std::string{output_filename}.c_str(), S_IREAD | S_IWRITE); if (outputFileDescriptor == -1) { @@ -70,7 +70,7 @@ absl::Status savePlanToJson( absl::Status savePlanToText( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename) { + std::string_view output_filename) { std::ofstream stream(output_filename); auto result = parseBinaryPlan(plan); @@ -85,7 +85,7 @@ absl::Status savePlanToText( absl::Status savePlanToProtoText( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename) { + std::string_view output_filename) { int outputFileDescriptor = creat(std::string{output_filename}.c_str(), S_IREAD | S_IWRITE); if (outputFileDescriptor == -1) { diff --git a/src/substrait/textplan/converter/SaveBinary.h b/src/substrait/textplan/converter/SaveBinary.h index 8f51305b..d9158773 100644 --- a/src/substrait/textplan/converter/SaveBinary.h +++ b/src/substrait/textplan/converter/SaveBinary.h @@ -13,21 +13,21 @@ namespace io::substrait::textplan { // Serializes a plan to disk as a binary protobuf. absl::Status savePlanToBinary( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename); + std::string_view output_filename); // Serializes a plan to disk as a JSON-encoded protobuf. absl::Status savePlanToJson( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename); + std::string_view output_filename); // Calls the converter to store a plan on disk as a text-based substrait plan. absl::Status savePlanToText( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename); + std::string_view output_filename); // Serializes a plan to disk as a text-encoded protobuf. absl::Status savePlanToProtoText( const ::substrait::proto::Plan& plan, - const std::string_view& output_filename); + std::string_view output_filename); } // namespace io::substrait::textplan