From 8c1a99a43bf00f8775eb14333cecda74a0de475c Mon Sep 17 00:00:00 2001 From: David Sisson Date: Fri, 7 Jul 2023 22:19:46 -0700 Subject: [PATCH] Rebundling abseil as the old version on Ubuntu does not have SimpleHexAtoi. --- .gitmodules | 3 +++ src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp | 2 +- third_party/abseil-cpp | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) create mode 160000 third_party/abseil-cpp diff --git a/.gitmodules b/.gitmodules index 89f198ea..6da52c17 100644 --- a/.gitmodules +++ b/.gitmodules @@ -10,6 +10,9 @@ [submodule "third_party/fmt"] path = third_party/fmt url = https://github.com/fmtlib/fmt +[submodule "third_party/abseil-cpp"] + path = third_party/abseil-cpp + url = https://github.com/abseil/abseil-cpp.git [submodule "third_party/datetime"] path = third_party/datetime url = https://github.com/HowardHinnant/date.git diff --git a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp index e31c2289..abdb98b2 100644 --- a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp +++ b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp @@ -790,7 +790,7 @@ std::any SubstraitPlanRelationVisitor::visitExpressionFunctionUse( expr.mutable_scalar_function()->set_function_reference(funcReference); for (const auto& exp : ctx->expression()) { if (endsWith(exp->getText(), "_enum")) { - std::string str = absl::StripSuffix(exp->getText(), "_enum"); + std::string str{absl::StripSuffix(exp->getText(), "_enum")}; expr.mutable_scalar_function()->add_arguments()->set_enum_(str); continue; } diff --git a/third_party/abseil-cpp b/third_party/abseil-cpp new file mode 160000 index 00000000..c8a2f925 --- /dev/null +++ b/third_party/abseil-cpp @@ -0,0 +1 @@ +Subproject commit c8a2f92586fe9b4e1aff049108f5db8064924d8e