From 9561d1e21cf8c3f35d9873a8d8ea00d1cb4fb05c Mon Sep 17 00:00:00 2001
From: David Sisson <EpsilonPrime@users.noreply.github.com>
Date: Thu, 25 Jul 2024 20:24:31 -0700
Subject: [PATCH] Use the .clang-tidy file

---
 .clang-tidy               | 1 +
 scripts/run-clang-tidy.sh | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.clang-tidy b/.clang-tidy
index b65f4a8e..ae5cc0f8 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -77,6 +77,7 @@ Checks: >
   -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-unchecked-optional-access
 WarningsAsErrors: '*'
+ExtraArgs: ['-Wno-assertions']
 HeaderFilterRegex: 'io/substrait/*.\\.h$'
 AnalyzeTemporaryDtors: false
 FormatStyle: none
diff --git a/scripts/run-clang-tidy.sh b/scripts/run-clang-tidy.sh
index b3427a97..293ef869 100755
--- a/scripts/run-clang-tidy.sh
+++ b/scripts/run-clang-tidy.sh
@@ -4,7 +4,7 @@ SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 WORKDIR="$( cd $SCRIPTDIR/.. && pwd )"
 
 # Make compile_command.json
-rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_ROUNDTRIP_TESTING=ON -Wno-attributes
+rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_ROUNDTRIP_TESTING=ON
 # Build substrait protobuf
 pushd tmp/src/substrait/proto && make -j && popd || exit
 # Build textplan grammar