From adf84290bffb9624413a6d516f8eb82e9b3d7c48 Mon Sep 17 00:00:00 2001
From: David Sisson <EpsilonPrime@users.noreply.github.com>
Date: Thu, 14 Mar 2024 20:31:25 -0700
Subject: [PATCH] Turn off address sanitization by default.  We should add a
 separate build later to test without affecting the runtime anyway.

---
 .github/workflows/build_test.yml | 2 +-
 CMakeLists.txt                   | 2 +-
 export/planloader/CMakeLists.txt | 7 -------
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml
index c2107ddb..e69559ea 100644
--- a/.github/workflows/build_test.yml
+++ b/.github/workflows/build_test.yml
@@ -45,5 +45,5 @@ jobs:
       - name: Build
         run: ninja -C build
       - name: Test
-        run: ctest --test-dir build --output-on-failure --timeout 10 --repeat until-pass:2
+        run: ctest --test-dir build --output-on-failure --timeout 30
 
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2c977ce3..025d6c22 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -14,7 +14,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)
 
 option(SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD
        "Turns on address and undefined memory sanitization runtime checking."
-       ON)
+       OFF)
 
 if(${SUBSTRAIT_CPP_SANITIZE_DEBUG_BUILD})
   add_compile_options($<$<CONFIG:Debug>:-fsanitize=undefined>)
diff --git a/export/planloader/CMakeLists.txt b/export/planloader/CMakeLists.txt
index 2294572c..e33353a9 100644
--- a/export/planloader/CMakeLists.txt
+++ b/export/planloader/CMakeLists.txt
@@ -1,12 +1,5 @@
 # SPDX-License-Identifier: Apache-2.0
 
-if(CMAKE_BUILD_TYPE MATCHES Debug)
-  message(
-    WARNING
-      "The planloader library does not work well in Debug mode due to bundled heap checking."
-  )
-endif()
-
 add_library(planloader SHARED planloader.cpp)
 
 add_dependencies(planloader substrait_io)