From bfe2ff6ed0d510e0493a4b8b622103fe2a94f1be Mon Sep 17 00:00:00 2001 From: David Sisson Date: Mon, 29 Jan 2024 21:27:20 -0800 Subject: [PATCH] Fix for some errors occuring too often. --- src/substrait/textplan/SymbolTablePrinter.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/substrait/textplan/SymbolTablePrinter.cpp b/src/substrait/textplan/SymbolTablePrinter.cpp index 66329d96..5237e7d5 100644 --- a/src/substrait/textplan/SymbolTablePrinter.cpp +++ b/src/substrait/textplan/SymbolTablePrinter.cpp @@ -995,8 +995,9 @@ void SymbolTablePrinter::addInputsToExpression( symbolTable, *subquerySymbol, expression->mutable_subquery()->mutable_scalar()->mutable_input()); + } else { + SUBSTRAIT_FAIL("Internal Error: Known symbol is missing."); } - SUBSTRAIT_FAIL("Internal Error: Known symbol is missing."); } case ::substrait::proto::Expression_Subquery::kInPredicate: { // First visit the needle expressions. @@ -1024,8 +1025,9 @@ void SymbolTablePrinter::addInputsToExpression( expression->mutable_subquery() ->mutable_in_predicate() ->mutable_haystack()); + } else { + SUBSTRAIT_FAIL("Internal Error: Known symbol is missing."); } - SUBSTRAIT_FAIL("Internal Error: Known symbol is missing."); } break; } @@ -1046,8 +1048,9 @@ void SymbolTablePrinter::addInputsToExpression( expression->mutable_subquery() ->mutable_set_predicate() ->mutable_tuples()); + } else { + SUBSTRAIT_FAIL("Internal Error: Known symbol is missing."); } - SUBSTRAIT_FAIL("Internal Error: Known symbol is missing."); } case ::substrait::proto::Expression_Subquery::kSetComparison: { addInputsToExpression(