From e2f54bfb940caea385b6341aee8320b34b47fc26 Mon Sep 17 00:00:00 2001 From: David Sisson Date: Thu, 12 Sep 2024 01:08:39 -0700 Subject: [PATCH] fixed variable name --- .../textplan/parser/SubstraitPlanRelationVisitor.cpp | 6 +++--- .../textplan/parser/SubstraitPlanRelationVisitor.h | 2 +- .../parser/SubstraitPlanSubqueryRelationVisitor.cpp | 6 +++--- .../textplan/parser/SubstraitPlanSubqueryRelationVisitor.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp index dd08092..a47ead0 100644 --- a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp +++ b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp @@ -824,9 +824,9 @@ std::any SubstraitPlanRelationVisitor::visitRelationEmit( SymbolType::kRelation); auto parentRelationData = ANY_CAST(std::shared_ptr, parentSymbol->blob); - this->processingEmit = true; + this->processingEmit_ = true; auto result = visitChildren(ctx); - this->processingEmit = false; + this->processingEmit_ = false; auto parentRelationType = ANY_CAST(RelationType, parentSymbol->subtype); auto common = findCommonRelation(parentRelationType, &parentRelationData->relation); @@ -2030,7 +2030,7 @@ std::pair SubstraitPlanRelationVisitor::findFieldReferenceByName( std::shared_ptr& relationData, const std::string& name) { auto fieldReferencesSize = relationData->fieldReferences.size(); - if (isAggregate(symbol) && this->processingEmit) { + if (isAggregate(symbol) && this->processingEmit_) { fieldReferencesSize = 0; } diff --git a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.h b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.h index c2ed07d..0430866 100644 --- a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.h +++ b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.h @@ -205,7 +205,7 @@ class SubstraitPlanRelationVisitor : public SubstraitPlanTypeVisitor { bool hasSubquery(SubstraitPlanParser::ExpressionContext* ctx); const SymbolInfo* currentRelationScope_{nullptr}; // Not owned. - bool processingEmit{false}; + bool processingEmit_{false}; }; } // namespace io::substrait::textplan diff --git a/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.cpp b/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.cpp index 975b3f8..d6e310f 100644 --- a/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.cpp +++ b/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.cpp @@ -874,9 +874,9 @@ std::any SubstraitPlanSubqueryRelationVisitor::visitRelationEmit( SymbolType::kRelation); auto parentRelationData = ANY_CAST(std::shared_ptr, parentSymbol->blob); - this->processingEmit = true; + this->processingEmit_ = true; auto result = visitChildren(ctx); - this->processingEmit = false; + this->processingEmit_ = false; auto parentRelationType = ANY_CAST(RelationType, parentSymbol->subtype); auto common = findCommonRelation(parentRelationType, &parentRelationData->relation); @@ -2168,7 +2168,7 @@ SubstraitPlanSubqueryRelationVisitor::findFieldReferenceByName( std::shared_ptr& relationData, const std::string& name) { auto fieldReferencesSize = relationData->fieldReferences.size(); - if (isAggregate(symbol) && this->processingEmit) { + if (isAggregate(symbol) && this->processingEmit_) { fieldReferencesSize = 0; } diff --git a/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.h b/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.h index c21665b..825f2a0 100644 --- a/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.h +++ b/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.h @@ -217,7 +217,7 @@ class SubstraitPlanSubqueryRelationVisitor : public SubstraitPlanTypeVisitor { bool isWithinSubquery(SubstraitPlanParser::RelationContext* ctx); const SymbolInfo* currentRelationScope_{nullptr}; // Not owned. - bool processingEmit{false}; + bool processingEmit_{false}; }; } // namespace io::substrait::textplan