From 08ad96f4dd84597c5e72d697c8fd06100bd73861 Mon Sep 17 00:00:00 2001 From: Victor Barua Date: Fri, 9 Feb 2024 16:44:30 -0800 Subject: [PATCH] doc: clarify nullability information source for empty literals --- proto/substrait/algebra.proto | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/proto/substrait/algebra.proto b/proto/substrait/algebra.proto index 242c72869..43e609bcd 100644 --- a/proto/substrait/algebra.proto +++ b/proto/substrait/algebra.proto @@ -825,9 +825,11 @@ message Expression { UserDefined user_defined = 33; } - // whether the literal type should be treated as a nullable type. Applies to - // all members of union other than the Typed null (which should directly - // declare nullability). + // Whether the literal_type above should be treated as a nullable type. + // Applies to all members of the literal_type oneof EXCEPT: + // * Type null (must be nullable by definition) + // * Type.List empty_list (use Type.List::nullability) + // * Type.Map empty_map (use Type.Map::nullability) bool nullable = 50; // optionally points to a type_variation_anchor defined in this plan.