Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Inspector and InspectorComponent #64

Open
sudara opened this issue Aug 22, 2023 · 0 comments
Open

Refactor Inspector and InspectorComponent #64

sudara opened this issue Aug 22, 2023 · 0 comments
Labels
model

Comments

@sudara
Copy link
Owner

sudara commented Aug 22, 2023 •
edited
Loading

Right now the inspector passes 5 callbacks to InspectorComponent.

InspectorComponent then passes those around or passes them into button callbacks, etc.

Essentially the root and the overlay not being accessible to InspectorComponent is the source of the trouble.

Refactoring the InspectorComponent to take references to those two things and encapsulating most of the logic left in Inspector might also open up the ability to do #56
@sudara sudara added the model label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sudara