Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Linux Support #22

Open
2 of 4 tasks
sudara opened this issue Sep 10, 2023 · 8 comments
Open
2 of 4 tasks

Explicit Linux Support #22

sudara opened this issue Sep 10, 2023 · 8 comments

Comments

@sudara
Copy link
Owner

sudara commented Sep 10, 2023

See: https://forum.juce.com/t/new-module-profile-your-juce-ui-dsp-performance-with-perfetto/54589/56?u=sudara

  • Default location for dump files (right now it's (juce::File::SpecialLocationType::userHomeDirectory).getChildFile ("Downloads")
  • Add linux to the matrix on GitHub Actions. See potential failures here: Add cross-platform GitHub Actions tests #7 (comment)
  • Add jassert if folder isn't there / happy
  • Update docs to be more explicit about locations
@sudara
Copy link
Owner Author

sudara commented Sep 10, 2023

@psemiletov Can you let me know which location is best for you? What do you think a good default folder for the trace files is?

If you want to get it working before this issue is fixed, see the juce internals for how userHomeDirectory is resolved, you might need to make a Downloads folder there and then that should work?...

https://github.com/juce-framework/JUCE/blob/master/modules/juce_core/native/juce_Files_linux.cpp#L107-L115

@psemiletov
Copy link

Hello! The location does not matter (but, for example it can be userDocumentsDirectory /from JUCE File File::getSpecialLocation (const SpecialLocationType type)/, the important thing to produce trace file at all, and would be fine to know from the documentation where to find such file and what is file's name. When I ran my plugin with profiler, I saw profiler's messages at console, but can't find a file :(

@sudara
Copy link
Owner Author

sudara commented Sep 10, 2023

@psemiletov

Thanks! I'll move it to userDocumentsDirectory for now, there's a couple commits on the linux branch.

The name and location of the file are written to cout when the application is gracefully quit.

Please note that no file is written if you just kill the process (like hitting stop in an IDE).

I'll get tests on linux running in a branch to clear things up.

@sudara
Copy link
Owner Author

sudara commented Sep 10, 2023

For me, the following is logged to cout:

Wrote perfetto trace to: /Users/sudara/Downloads/perfetto-DEBUG-2023-09-10_1937.pftrace

@psemiletov
Copy link

When you merge it to main branch I'll be able to try it from Drumlabooh cmake build :)

@sudara
Copy link
Owner Author

sudara commented Sep 10, 2023

Looks like there are some build issues in CI that I will have to come back to look at.

In the meantime, you can check cout to see where it's being written or run off the branch.

@TheOnlyJoey
Copy link

Any updates on this? Also willing to look into this if @sudara does not have the time a the moment

@sudara
Copy link
Owner Author

sudara commented Mar 3, 2024

@TheOnlyJoey Hey hey! I'm just back from vacation — if you are motivated, I'd say go for it! It shouldn't be too tough, it's more about getting things happy in CI, hopefully perfetto itself is happy on linux?...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants