Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert when perfetto is enabled #5

Open
sudara opened this issue Dec 12, 2022 · 3 comments
Open

Alert when perfetto is enabled #5

sudara opened this issue Dec 12, 2022 · 3 comments

Comments

@sudara
Copy link
Owner

sudara commented Dec 12, 2022

It's easy to forgot to leave perfetto "on".

Since we often want to trace in release, this can be bad.

In the readme i suggest adding a test to CI to confirm it wasn't left on.

However, perhaps we should at least be alerting via DBG or that perfetto is enabled and how much memory was allocated?

@sudara sudara mentioned this issue Dec 12, 2022
3 tasks
@benthevining
Copy link
Collaborator

Doesn't JUCE provide a macro to print a custom compiler warning or message? We could use that to print whether or not Perfetto is enabled.

Or do you mean to print this information during CMake configure-time?

@sudara
Copy link
Owner Author

sudara commented Dec 12, 2022

I was thinking run time. However, since most profiling is done in release I guess that rules out DBG's usefulness... Configure time will probably get lost... compile time works!

I added something in my UI, just because it's easy to forget...

AudioPluginHost - 2022-12-12 16@2x

@benthevining
Copy link
Collaborator

That's a good idea! The module could also provide something like a PerfettoStatusLabel widget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants