Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances of the Editor class are leaked. #139

Open
superfell opened this issue Oct 21, 2021 · 0 comments
Open

Instances of the Editor class are leaked. #139

superfell opened this issue Oct 21, 2021 · 0 comments
Labels

Comments

@superfell
Copy link
Owner

Describe the bug
When a main soqlx window is closed, the associated Explorer class instance is not deallocated.

Discovered during work on #138 which had similar issues for some of its UI related classes that load UIs from Nibs.

As described in ZKLoginController, any UI component that uses bindings, and binds to the File Owner will create a retain cycle which will prevent the class from being deallocated.

The fix is the same as in ZKLoginController, move the state that the UI binds to into a separate class/instance from the File Owner instance. There's quite a bit of binding in the main UI window so this is a larger fix than the login ones.

@superfell superfell added the bug label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant