Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The login sheet doesn't appear #141

Open
superfell opened this issue Oct 27, 2021 · 1 comment
Open

The login sheet doesn't appear #141

superfell opened this issue Oct 27, 2021 · 1 comment
Labels
Milestone

Comments

@superfell
Copy link
Owner

via Twitter https://twitter.com/seotoni/status/1453087579776196613

It turns out if in an older version of SoqlX you get an entry into the servers list that NSURL doesn't consider to be a valid url, the LoginTargetController ends up trying to insert nil into an array, which causes an exception which then means the code that shows the login sheet never executes.

The fix is pretty simple, but it'd also be good to see if there's a good way to catch unexpected exceptions and show then in the UI, or force a hard crash that crash reporter would then log.

New in v4.2

@superfell superfell added the bug label Oct 27, 2021
@superfell superfell modified the milestones: v4.2, v4.3 Oct 27, 2021
@superfell
Copy link
Owner Author

specific issue fixed in fee2be1

global exception handler still TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant