Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for anchors as buttons #35

Open
milogert opened this issue Dec 8, 2019 · 1 comment
Open

Reason for anchors as buttons #35

milogert opened this issue Dec 8, 2019 · 1 comment

Comments

@milogert
Copy link

milogert commented Dec 8, 2019

I noticed it was very intentional in d3cf314, but why did this happen? Obviously you had something in mind so I might just be missing something.

Mainly, I keep encountering #17 which is easily work-around-able, but with a button tag it wouldn't even be an issue in a lot of cases.

Thanks for the great work! I love the library so far.

@lalaithion
Copy link

lalaithion commented Aug 3, 2022

This also breaks the disabled styling of buttons (https://bulma.io/documentation/elements/button/) by default; using disabled True doesn't work, you have to use attribute "disabled" "", and if you want to do something like disabled x then you have to expand that to

    if x then
        attribute "disabled" ""

    else
        attribute "style" ""

If there's a strong reason to prefer <a> to <button>, you could provide an alias for disabled defined as the above in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants