From 3ee6c9a10fc316fa9b5c45fcf6d3c48abeb33521 Mon Sep 17 00:00:00 2001
From: Jolanda <ad11jnav@uwcad.it>
Date: Sun, 28 Oct 2018 16:37:11 +0800
Subject: [PATCH] prevents <a> elements without `href` from causing a page
 reload adds a `href = ""` attribute to all elements using <a> relies on
 reordering of elements in `node` function to work (user specified `href`
 attribute will take precedence because specified last)

closes #17
---
 src/Bulma/Components.elm | 21 ++++++++++++---------
 src/Bulma/Layout.elm     |  4 ++--
 src/Helpers.elm          |  2 +-
 3 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/Bulma/Components.elm b/src/Bulma/Components.elm
index 319e34d..f6d8da7 100644
--- a/src/Bulma/Components.elm
+++ b/src/Bulma/Components.elm
@@ -317,7 +317,7 @@ import Bulma.Elements exposing ( Image, easyDelete, Button, ButtonModifiers, but
 
 import Html exposing ( Html, Attribute, text, div, p, a, ul, li, span, input )
 import Html.Events exposing ( onClick )
-import Html.Attributes exposing ( attribute, class, type_ )
+import Html.Attributes exposing ( attribute, class, type_, href )
 
 
 -- BREADCRUMB ------------------------------------------------------------------
@@ -490,7 +490,7 @@ cardIcon = node "p" [ B.cardHeaderIcon ]
 
 {-| -}
 cardIconLink : List (Attribute msg) -> List (Icon msg) -> CardHeaderItem msg
-cardIconLink = node "a" [ B.cardHeaderIcon ]
+cardIconLink = node "a" [ B.cardHeaderIcon, href "" ]
 
 {-| -}
 easyCardIconLink : List (Attribute msg) -> msg -> Icon msg -> CardHeaderItem msg
@@ -538,7 +538,7 @@ cardFooterItem = node "p" [ B.cardFooterItem ]
 
 {-| -}
 cardFooterItemLink : List (Attribute msg) -> List (Html msg) -> CardFooterItem msg
-cardFooterItemLink = node "a" [ B.cardFooterItem ]
+cardFooterItemLink = node "a" [ B.cardFooterItem, href "" ]
 
 
 -- DROPDOWN --------------------------------------------------------------------
@@ -659,7 +659,7 @@ dropdownMenu attrs attrs_ items
 {-| A synonym for `a.dropdown-item.is-active`.
 -}
 dropdownItemLink : IsActive -> List (Attribute msg) -> List (Html msg) -> DropdownItem msg
-dropdownItemLink isActive = node "a" [ B.dropdownItem, if isActive then B.isActive else B.none ]
+dropdownItemLink isActive = node "a" [ B.dropdownItem, if isActive then B.isActive else B.none, href "" ]
 
 {-| A synonym for `div.dropdown-item.is-active`.
 -}
@@ -1073,7 +1073,7 @@ When its first argument is `True`, it transforms into a `navbarCross`.
 
 -}
 navbarBurger : IsActive -> List (Attribute msg) -> List (Html msg) -> NavbarBurger msg
-navbarBurger isActive = node "a" [ B.navbarBurger, if isActive then B.isActive else B.none ]
+navbarBurger isActive = node "a" [ B.navbarBurger, if isActive then B.isActive else B.none, href "" ]
 
 {-| A simple "X" character; the active version of `navbarBurger`.
 -}
@@ -1111,7 +1111,7 @@ You can use this element in `navbarStart`, `navbarEnd`, `navbarBrand`, and `navb
 When the first argument is `True`, the link will be highlighted.
 -}
 navbarItemLink : IsActive -> List (Attribute msg) -> List (Html msg) -> NavbarItem msg
-navbarItemLink isActive = node "a" [ B.navbarItem, if isActive then B.isActive else B.none ]
+navbarItemLink isActive = node "a" [ B.navbarItem, if isActive then B.isActive else B.none, href "" ]
 
 {-| This is a dropdown item that expects `navbarLink` and `navbarDropdown` tags.
 When the first argument is `True` the menu contents will be visible.
@@ -1153,7 +1153,7 @@ hoverableNavbarItemDropdown dir attrs link dropdowns
 {-| This element represents `a.navbar-link`. It is only useful as a child of `navbarDropdown`.
 -}
 navbarLink : List (Attribute msg) -> List (Html msg) -> NavbarLink msg
-navbarLink = node "a" [ B.navbarLink ]
+navbarLink = node "a" [ B.navbarLink, href "" ]
 
 {-| -}
 type alias IsBoxed = Bool
@@ -1230,7 +1230,7 @@ type alias PaginationPartition msg = Html msg
 
 {-| -}
 paginationPrev : List (Attribute msg) -> List (Html msg) -> PaginationPartition msg
-paginationPrev = node "a" [ B.paginationPrevious ]
+paginationPrev = node "a" [ B.paginationPrevious, href "" ]
 
 {-| -}
 easyPaginationPrev : List (Attribute msg) -> msg -> String -> PaginationPartition msg
@@ -1239,7 +1239,7 @@ easyPaginationPrev attrs msg
 
 {-| -}
 paginationNext : List (Attribute msg) -> List (Html msg) -> PaginationPartition msg
-paginationNext = node "a" [ B.paginationNext ]
+paginationNext = node "a" [ B.paginationNext, href "" ]
 
 {-| -}
 easyPaginationNext : List (Attribute msg) -> msg -> String -> PaginationPartition msg
@@ -1270,6 +1270,7 @@ paginationLink current
     , case current of
         True  -> B.isCurrent
         False -> B.none
+    , href ""
     ]
 
 {-| -}
@@ -1348,6 +1349,7 @@ panelLink active
     , case active of
         True  -> B.isActive
         False -> B.none
+    , href ""
     ]
 
 {-| 
@@ -1433,6 +1435,7 @@ panelTab active
     [ case active of
         True  -> B.isActive
         False -> B.none
+    , href ""
     ]
 
 
diff --git a/src/Bulma/Layout.elm b/src/Bulma/Layout.elm
index eed4d15..7e2e9c3 100644
--- a/src/Bulma/Layout.elm
+++ b/src/Bulma/Layout.elm
@@ -150,7 +150,7 @@ import Bulma.Classes as B
 import Bulma.Modifiers as Modifiers exposing (..)
 
 import Html exposing ( Html, Attribute, div, p, text )
-import Html.Attributes as Attr exposing ( class )
+import Html.Attributes as Attr exposing ( class, href )
 
 
 -- CONTAINER -------------------------------------------------------------------
@@ -287,7 +287,7 @@ levelItemText = node "p" [ B.levelItem ]
 
 {-| -}
 levelItemLink : List (Attribute msg) -> List (Html msg) -> LevelItem msg
-levelItemLink = node "a" [ B.levelItem ]
+levelItemLink = node "a" [ B.levelItem, href "" ]
 
 {-| -}
 easyLevelItemWithHeading : List (Attribute msg) -> String -> String -> LevelItem msg
diff --git a/src/Helpers.elm b/src/Helpers.elm
index 09d7cbd..69c0c14 100644
--- a/src/Helpers.elm
+++ b/src/Helpers.elm
@@ -68,5 +68,5 @@ ls x = [ x ]
 node : String -> List (Attribute msg) -> List (Attribute msg) -> List (Html msg) -> Html msg
 node tag attrs_ attrs
   = Html.node tag
-    <| attrs ++ attrs_
+    <| attrs_ ++ attrs