Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is v0.0.8 ? #2

Closed
addshore opened this issue Aug 21, 2023 · 8 comments
Closed

Where is v0.0.8 ? #2

addshore opened this issue Aug 21, 2023 · 8 comments

Comments

@addshore
Copy link

Hi @survivorbat

I just started using this package and was going to provide a PR improvement for some many2many relation stuff.
However I appear to be using v0.0.8 but I can't actually find that tag / the code in this repo?
Can you offer some help? :)

@survivorbat
Copy link
Owner

Hey @addshore! Thanks for showing interest in the development. I was actually quite stumped when I read your issue because I forgot where v0.0.8 came from as well.

v0.0.8 and all the versions in between were draft/pre-release versions that incorporated the feature that is now gorm-like but were later abandoned in favor of a separate plugin. It appears my own projects are also using this ghost version. I don't recall why I turned them into tags, rather than just using the git hashes.

I suppose this would be rectified with a new tag on master like v0.0.9, although I'd prefer (finally) releasing v1.0.0 to justify a breaking change removing this abandoned code.

Hope that clears up the confusion, the intended state of the library should be the master branch. I'll delete the 2 branches with this unfinished code asap :)

@addshore
Copy link
Author

Hehe, nothing like coming back to a project after a year.

The patch I wrote is addshore@1f34f64 and is actually for the functionality on the feature/improve-like branch
But it sounds like you might be getting rid of that functionality? (personally I quite like it ;))

@survivorbat
Copy link
Owner

This one is much more functional than whatever is in there: gorm-like

@addshore
Copy link
Author

Lovely, I'll take a look and try to transfer over :)
Might be worth noting that one in the README too :)

@addshore
Copy link
Author

well, that was easy...

-       deepgorm "github.com/survivorbat/gorm-deep-filtering"
+       gormlike "github.com/survivorbat/gorm-like"


-       DB.Use(deepgorm.New(deepgorm.Wildcards()))
+       DB.Use(gormlike.New(gormlike.WithCharacter("*")))

No other changes needed

@survivorbat
Copy link
Owner

I do intend to remove the functionality from deepgorm, gormlike should be enough. But that would be v1.0.0 ;)

@survivorbat
Copy link
Owner

Hey @addshore! A bit unrelated, but will you merge your improvements to master? I think it'd make a great addition

@addshore
Copy link
Author

#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants