Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to handle < A0 and > C8. #30

Open
sustained opened this issue Sep 7, 2019 · 0 comments
Open

Figure out how to handle < A0 and > C8. #30

sustained opened this issue Sep 7, 2019 · 0 comments
Assignees
@sustained
Labels
priority: Low The issue is insignificant. status: Accepted It's going to be worked on, sooner or later. type: Enhancement Something existing will be improved.

Comments

@sustained
Copy link
Owner

sustained commented Sep 7, 2019 •
edited
Loading

After this commit the note/octave offset-related stuff works really well for most cases but there are still a few things to think about and fix, mostly relating to < A0 and > C8.

I mean, as much as 88 keys makes sense, there exist now 108-key grand pianos, so we should probably only special-case anything outside of the range C0 - B8.

Relevant code here, here, here, here and here.
@sustained sustained added priority: Low The issue is insignificant. status: Accepted It's going to be worked on, sooner or later. type: Enhancement Something existing will be improved. labels Sep 7, 2019
@sustained sustained self-assigned this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sustained sustained

Labels
priority: Low The issue is insignificant. status: Accepted It's going to be worked on, sooner or later. type: Enhancement Something existing will be improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sustained