From 67574e7c021e034ff586a5b7120af0bf36c979b8 Mon Sep 17 00:00:00 2001 From: Sveinbjorn Thordarson Date: Wed, 4 Oct 2023 00:29:56 +0000 Subject: [PATCH] Optimized nib logic + updated internal docs --- Application/PlatypusWindowController.m | 3 ++- Application/Resources/Platypus-Info.plist | 2 +- CHANGES.txt | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Application/PlatypusWindowController.m b/Application/PlatypusWindowController.m index e1af10a6..2fffaab5 100644 --- a/Application/PlatypusWindowController.m +++ b/Application/PlatypusWindowController.m @@ -418,7 +418,8 @@ - (BOOL)createApplication:(NSString *)destination { spec[AppSpecKey_SymlinkFiles] = @((BOOL)[createSymlinksCheckbox intValue]); spec[AppSpecKey_StripNib] = @((BOOL)[stripNibFileCheckbox intValue]); if (spec[AppSpecKey_StripNib]) { - spec[AppSpecKey_NibPath] = [[NSBundle mainBundle] pathForResource:CMDLINE_NIB_OPT_NAME ofType:nil];; + spec[AppSpecKey_NibPath] = [[NSBundle mainBundle] pathForResource:CMDLINE_NIB_OPT_NAME ofType:nil]; + // spec[AppSpecKey_StripNib] = @(NO); } spec[AppSpecKey_Overwrite] = @YES; if (![[DEFAULTS stringForKey:DefaultsKey_SigningIdentity] isEqualToString:@"None"]) { diff --git a/Application/Resources/Platypus-Info.plist b/Application/Resources/Platypus-Info.plist index 56148831..11aad44d 100644 --- a/Application/Resources/Platypus-Info.plist +++ b/Application/Resources/Platypus-Info.plist @@ -411,7 +411,7 @@ CFBundleSignature ???? CFBundleVersion - 1251 + 1252 LSApplicationCategoryType public.app-category.developer-tools LSMinimumSystemVersion diff --git a/CHANGES.txt b/CHANGES.txt index bdc25718..281e61ca 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -22,9 +22,10 @@ For future versions... TODO: Harden CI testing for this old project TODO: Fix selection change when item is deleted from the Bundled Files List -For 5.4.2 - 02/10/2023 +For 5.4.2 - 03/10/2023 * Fixed bug where the argument settings window would lock up - TODO: Keep an optimized copy of the nib in app bundle to save expensive step when creating + * Better support for Dark Mode + * Performance optimizations in the app build process For 5.4.1 - 22/10/2022 * Fixed signing issues