feat: add rule no-deprecated-raw-special-elements
#918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0ee149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @ota-meshi, would it be possible to have this rule have different test outputs for each svelte version? As fixes only apply to Svelte 5 |
ota-meshi
force-pushed
the
feat/add-no-invalid-html-elements
branch
from
b95c268
to
71abe97
Compare
|
You can exclude tests for each package version you are testing by placing a |
|
The rule should only be tested in Svelte 5, meaning tests for earlier versions should not produce errors related to Svelte 5 behavior. |
ota-meshi
reviewed
Nov 27, 2024
packages/eslint-plugin-svelte/src/rules/no-invalid-html-elements.ts
Outdated
Show resolved
Hide resolved
mikededo
force-pushed
the
feat/add-no-invalid-html-elements
branch
from
851cbef
to
0ef42f3
Compare
mikededo
force-pushed
the
feat/add-no-invalid-html-elements
branch
from
a624263
to
bc20978
Compare
mikededo
force-pushed
the
feat/add-no-invalid-html-elements
branch
from
a77b03e
to
1be1e99
Compare
ota-meshi
changed the title
no-invalid-html-elementsno-deprecated-raw-special-elements
ota-meshi
pushed a commit
that referenced
this pull request
Nov 28, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## eslint-plugin-svelte@3.0.0-next.1 ### Minor Changes - [#918](#918) [`5da98c9`](5da98c9) Thanks [@mikededo](https://github.com/mikededo)! - Added new `no-deprecated-raw-special-elements` rule - [#836](#836) [`3fa90aa`](3fa90aa) Thanks [@renovate](https://github.com/apps/renovate)! - feat: support for typescript-eslint v8 to `svelte/indent` rule Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Svelte 5 specific rule that ensure special elements are used with
svelte:prefix. This rule will help on migrating from Svelte 4, as suchelements were supported without the prefix in Svelte 4.
Adds a new rule that recommends not using raw special elements and fixes to
using the
svelte:prefix. Raw special elements are deprecated from v5 on.Closes #913