Ideas for AST changes

[kdy1]

We want to collect ideas about AST changes.

• Change boxing rules: perf(es/ast): Properly box variants #9158

[magic-akari]

Use Function everywhere

const obj = {
    x() {}, // Function ✅
    set a(v) {}, // should use Function
    get b() {}, // should use Function
}

function foo() {} // Function ✅
const a = () => {} // should use Function
const b = () => expr; // We should use another form of representation, but it can be conveniently converted into a Function.

class clazz {
    x() {} // Function ✅
    set a(v) {} // Function ✅
    get b() {} // Function ✅
}

SWC AST Viewer

---

Use 👍 or 👎 to express your opinion.

[magic-akari]

Merge ForInStmt/ForOfStmt into forXStmt

---

Use 👍 or 👎 to express your opinion.

[devongovett]

Try using an arena allocator (eg bumpalo) for heap allocated values like Vec and Box. Would require passing lifetimes around unfortunately but apparently this is where oxc gets some of its performance wins. Could be worth testing to see how much impact it has.

[magic-akari]

Class

The attribute is_abstract should belong to the ClassDecl, but now it is an attribute of the Class.

SWC AST Viewer

[kdy1]

• BindingIdent should not have ident: Ident.
• PrivateName should not have id: Ident.

[kdy1]

Rename: ImportStarAsSpecifier => ImportNamespaceSpecifier.

[kdy1]

Rename variants in TypeScript enums.

Current:

#[ast_node]
#[derive(Eq, Hash, Is, EqIgnoreSpan)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
pub enum TsTypeElement {
    #[tag("TsCallSignatureDeclaration")]
    TsCallSignatureDecl(TsCallSignatureDecl),

    #[tag("TsConstructSignatureDeclaration")]
    TsConstructSignatureDecl(TsConstructSignatureDecl),

    #[tag("TsPropertySignature")]
    TsPropertySignature(TsPropertySignature),

    #[tag("TsGetterSignature")]
    TsGetterSignature(TsGetterSignature),

    #[tag("TsSetterSignature")]
    TsSetterSignature(TsSetterSignature),

    #[tag("TsMethodSignature")]
    TsMethodSignature(TsMethodSignature),

    #[tag("TsIndexSignature")]
    TsIndexSignature(TsIndexSignature),
}

New:

#[ast_node]
#[derive(Eq, Hash, Is, EqIgnoreSpan)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
pub enum TsTypeElement {
    #[tag("TsCallSignatureDeclaration")]
    CallSignature(TsCallSignatureDecl),

    #[tag("TsConstructSignatureDeclaration")]
    Construct(TsConstructSignatureDecl),

    #[tag("TsPropertySignature")]
    Property(TsPropertySignature),

    #[tag("TsGetterSignature")]
    Getter(TsGetterSignature),

    #[tag("TsSetterSignature")]
    Setter(TsSetterSignature),

    #[tag("TsMethodSignature")]
    Method(TsMethodSignature),

    #[tag("TsIndexSignature")]
    Index(TsIndexSignature),
}

[kdy1]

Fix TypeScript namespace vs module

[kdy1]

Remove Key and merge PrivateName into PropName

[kdy1]

• JSX => Jsx

or

• Ts => TS

[kdy1]

Take trait => Default trait