Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Episode 5: Typo in instructions for referring to commits #875

Closed
dicksonlaw583 opened this issue Apr 11, 2022 · 2 comments · Fixed by #1001
Closed

Episode 5: Typo in instructions for referring to commits #875

dicksonlaw583 opened this issue Apr 11, 2022 · 2 comments · Fixed by #1001

Comments

@dicksonlaw583
Copy link
Contributor

In Episode 5, this is the wording for how to refer to commits by ID:

We can also refer to commits using those long strings of digits and letters that git log displays.

But git log has not been called thus far during the episode. I recommend amending this to git show, as that command is the most recently run and does contain the alphanumeric string mentioned.

If you are OK with this change, I can put in a PR for this on Thursday.
@dicksonlaw583 dicksonlaw583 mentioned this issue Apr 20, 2022
Closed
@martinosorb
Copy link
Contributor

@dicksonlaw583 apologies for not responding to this. git log is explained in the previous episode of the lesson. We could write 'that both git log and git show display' here?

dicksonlaw583 added a commit to dicksonlaw583/git-novice that referenced this issue Jul 3, 2024
@dicksonlaw583
Mention both git log and git show (swcarpentry#875)
4ce061a 
In episode 5, mention that both `git log` and `git show` display IDs that can identify commits.
@dicksonlaw583 dicksonlaw583 mentioned this issue Jul 3, 2024
Merged
@dicksonlaw583
Copy link
Contributor Author

@martinosorb The PR is ready: #1001

martinosorb added a commit that referenced this issue Jul 14, 2024
@martinosorb
Merge pull request #1001 from dicksonlaw583/dev-episode5-gitlog
6949126 
Mention both git log and git show (#875)
github-actions bot pushed a commit that referenced this issue Jul 14, 2024
@actions-user
markdown source builds
759e141 
Auto-generated via {sandpaper}
Source  : 6949126
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-07-14 17:06:39 +0000
Message : Merge pull request #1001 from dicksonlaw583/dev-episode5-gitlog

Mention both git log and git show (#875)
github-actions bot pushed a commit that referenced this issue Jul 14, 2024
@actions-user
site deploy
b608d23 
Auto-generated via {sandpaper}
Source  : 759e141
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-07-14 17:07:33 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6949126
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-07-14 17:06:39 +0000
Message : Merge pull request #1001 from dicksonlaw583/dev-episode5-gitlog

Mention both git log and git show (#875)
github-actions bot pushed a commit that referenced this issue Jul 16, 2024
@actions-user
site deploy
abcc7e3 
Auto-generated via {sandpaper}
Source  : 759e141
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-07-14 17:07:33 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6949126
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-07-14 17:06:39 +0000
Message : Merge pull request #1001 from dicksonlaw583/dev-episode5-gitlog

Mention both git log and git show (#875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dicksonlaw583 @martinosorb