-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings Dart Sass 3.0.0 #470
Comments
I think the problem is from the GitHub Page gem which does not support the most recent If I wear to update, not sure how compatible it will be as a GitHub page. |
Hmm, fair. Is this a roadblock that needs to be cleared from GitHub Pages' side or is manual conversion possible? I use GitLab pages, I am fairly sure they have different compatibilities. |
From the link https://sass-lang.com/documentation/breaking-changes/import/ it says:
So the new way might be compatible with the older |
@Crossed-Omega good news! After digging into how to migrate and remove the deprecated scss notation, it seems that there's no problem running it with the current version of I had to run the sass migration on the fontawesome lib still, but now there's no more warning that I can see. |
Actually let me track back, it seemed fine locally but I think I might have spoken too soon as the github hosted version is not reacting well to it. |
So I had both version of jekyll-sass-converter locally (1.5.2 and 3) that's why it was working fine with v3 but when I switched to the GitHub page one v1.5.2, the style wasn't rendering at all. So you can use #471 and #474 to make it v3 compatible (and remove the warnings), however it won't work on GitHub page, so I am not sure how to do. I'll revert for now. |
I think the best fix, I can provide is to quiet the warnings for now 🤔 Once the github page uses the latest converter, I'll push the sass update. |
Brilliant, thanks a bunch! |
With #478 I can remove all but one warnings for the sass. I guess that's the max I can do for now. |
Upon using
bundle exec jekyll serve
the generator emits many warnings about the deprecation of the @import system in Dart Sass.The webpage linked by Sass has an automatic migrator that can be ran over the style sheets with
or, alternatively on Windows, downloading the dart executable and running (dry run and normal run emit the same exception)
This however yields an exception that complains about an element miss in a list. Fairly sure that this is a bug on Sass-migrators' side.
Obviously, it would be nice to fix the deprecation warnings so as to not clutter the generation output, as well as future stability.
The text was updated successfully, but these errors were encountered: