Use JS ratio helper to calculate ratio. Closes #12

sylvainjule · Nov 23, 2021 · 6d99bef · 6d99bef
1 parent da8e28d
commit 6d99bef
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/index.js b/index.js
diff --git a/lib/fields/imageradio.php b/lib/fields/imageradio.php
@@ -26,15 +26,6 @@
             return $mobile;
         },
         'ratio' => function($ratio = '1/1') {
-        	$computed = 1;
-
-            if (preg_match('/(\d+)(?:\s*)([\/])(?:\s*)(\d+)/', $ratio, $matches) !== false){
-                $computed = $matches[3] / $matches[1];
-            }
-
-            $computed = $computed * 100;
-            $ratio    = round($computed, 3, PHP_ROUND_HALF_DOWN);
-
             return $ratio;
         },
     ),

diff --git a/src/components/field/ImageRadio.vue b/src/components/field/ImageRadio.vue
@@ -18,4 +18,4 @@ export default {
 
 <style lang="scss">
     @import '../../assets/css/styles.scss'
-</style>
+</style>
diff --git a/src/components/input/ImageRadioInput.vue b/src/components/input/ImageRadioInput.vue
@@ -33,8 +33,8 @@ export default {
     },
     computed: {
         padding() {
-            return 'padding-top:'+ this.ratio + '%;'
-        }
+            return 'padding-top:'+ this.$helper.ratio(this.ratio, 'auto', false)
+        },
     }
 }
-</script>
+</script>