-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PasXip.pas issue. #458
Comments
Please try with the above commit, and close if it is OK for you. I tried to fix all wrong occurrences of DWORD in this unit. |
Builds & runs OK. Thank you. |
I was still experiencing issues with 64bit. {$WARNINGS OFF} { $D-,L-} {$I Synopse.inc} interface uses ////////////////////////////////////////////////////////////////////// type I will advise if I have any more issues. |
Please try with the above commit. Using a function like in mORMot 2 seems a cleaner way. |
No problem. Either way seems to work. |
These variables must also be
P.S. Also, there may be errors related to the fact that the variables used to store the size/offset have a |
About the use of cardinal, this would need to support the Zip64 format, which is clearly out of scope of this small unit (it is a bit complex to implement). We have mormot.core.zip.pas for full zip support, including the Zip64 format. |
Hi Team,
I recently started to play in 64 bit. Normally I was 32 bit exclusive.
I ran up against an issue with paszip.pas, used in a couple of places in various 3rd Party libraries.
I kept geting an error at line 4341 or thereabouts: file_ := INVALID_HANDLE_VALUE;
Tracing, I found variable file_ was defined at line around 3963 as a DWORD: file_: dword;
This is fine in 32bit but problematic in 64bit.
The solution was to change the declaration to: file_: THandle;
Now paszip.pas builds without issue in both 32 & 64 bit.
HTH in some way..
Regards,
Ian
The text was updated successfully, but these errors were encountered: